Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twolimbcc #83

Merged
merged 43 commits into from
Mar 5, 2017
Merged

Twolimbcc #83

merged 43 commits into from
Mar 5, 2017

Conversation

munozyanez
Copy link
Contributor

Completed all tasks. Working both limbs and revised DH for both legs.
@jgvictores , remember you hardcoded the robot name as "teoSim", so check it properly to avoid problems.
Movement is still not fine, but it will be an issue in new repo.

jgvictores and others added 13 commits November 7, 2016 18:49
…bCartesianControl.hpp

	modified:   libraries/TrajectoryLib/GaitTrajectory.cpp
	modified:   libraries/TrajectoryLib/GaitTrajectory.cpp
…rImpl.cpp

	modified:   libraries/TrajectoryLib/GaitTrajectory.cpp
	modified:   libraries/TrajectoryLib/GaitTrajectory.hpp
	modified:   libraries/gait
	modified:   libraries/gait
	modified:   share/kinematics/rightLegKinematics.ini
	modified:   libraries/gait
	modified:   share/kinematics/rightLegKinematics.ini
…rImpl.cpp

	modified:   libraries/TeoYarp/BasicTwoLimbCartesianControl/ICartesianControlImpl.cpp
	modified:   libraries/TeoYarp/BasicTwoLimbCartesianControl/RateThreadImpl.cpp
	modified:   libraries/TeoYarp/ITwoLimbCartesianControl.h
	modified:   libraries/TrajectoryLib/GaitTrajectory.cpp
	modified:   libraries/gait
	modified:   share/kinematics/leftLegKinematics.ini
@jgvictores
Copy link
Member

@munozyanez Thanks, looking much better. Could you please review and resolve the merge conflicts to enable the automatic merge?
Haven't checked the details, but hopefully it's just something to do with git submodules and all you have to do is force your version.

@munozyanez
Copy link
Contributor Author

I can not say what to keep or not in teo-main/libraries/TeoYarp/CMakeLists.txt
Find attached difference text files
CMakeLists_BACKUP_4303.txt
CMakeLists_BASE_4303.txt
CMakeLists_LOCAL_4303.txt
CMakeLists_REMOTE_4303.txt

@PeterBowman
Copy link
Member

@munozyanez I've merged develop into the derived branch twolimbcc-merged, please check if you are OK with these changes: 545a250. Most importantly, BasicTwoLimbCartesianControl and TwoLimbCartesianControlServer have been enabled as dynamically loaded plugins and their respective .ini files were included as well. Then, you just merge twolimbcc-merged into twolimbcc and the conflicts should be gone (not sure about gait and how submodules work, though).

BTW I can't compile this code with the checked out revision of gait (roboticslab-uc3m/gait@d0dbd6d). I'm getting a 'abs' is not a member of 'std' error at line 437 in src/tools/cpp.

@jgvictores
Copy link
Member

BTW I can't compile this code with the checked out revision of gait (roboticslab-uc3m/gait@d0dbd6d). I'm getting a 'abs' is not a member of 'std' error at line 437 in src/tools/cpp

Touched at roboticslab-uc3m/gait@6f717d9

@jgvictores
Copy link
Member

Version of gaitused updated in roboticslab-uc3m/teo-main@f10f7b7

@jgvictores jgvictores merged commit a57df1d into develop Mar 5, 2017
@jgvictores
Copy link
Member

Final merge at roboticslab-uc3m/teo-main@94e6baa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants