Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARP 3.0 upgrade path #83

Closed
3 tasks done
PeterBowman opened this issue Apr 19, 2019 · 5 comments
Closed
3 tasks done

YARP 3.0 upgrade path #83

PeterBowman opened this issue Apr 19, 2019 · 5 comments

Comments

@PeterBowman
Copy link
Member

PeterBowman commented Apr 19, 2019

Following #65 (forward compat with YARP 3.x), #78 (upgrade and require YCM v0.10+) and #73 (migrating to Xenial builds in Travis), minimum required YARP version is going to be bumped from v2.3.70 to v3.0 soon enough. This issue will track code cleanup (remove pre-3.0 stuff), blockers and announcements.

TODOs

Blockers (mostly related to a recent OpenNI2->RGBDSensor device migration, roboticslab-uc3m/vision#83)

@PeterBowman
Copy link
Member Author

PeterBowman commented Apr 25, 2019

TEO's PCs now run YARP 3.1.1. Note that teo-head is a Trusty system, whereas manipulation and locomotion already moved on to Xenial.

Tracked at roboticslab-uc3m/teo-main#49.

Edit: teo-head done, too (running current YARP master because of robotology/yarp#2009).

@PeterBowman
Copy link
Member Author

PeterBowman commented May 13, 2019

Since all blockers have been resolved, I'm going to gradually start enforcing the YARP 3.0+ requisite in several repositories. Please git pull to the latest master branch or check out YARP's v3.1.1 git tag. It is recommended to uninstall first.

cc @roboticslab-uc3m

Edit: v3.0.1 -> v3.1.1.

@PeterBowman PeterBowman self-assigned this May 13, 2019
@PeterBowman PeterBowman moved this from To do to In progress in [ROBOTICSLAB] May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/teo-configuration-files that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/asibot-configuration-files that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/project-generator that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/asibot-hmi that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/tools that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/xgnitive that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/teo-follow-me that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/teo-self-presentation that referenced this issue May 13, 2019
PeterBowman added a commit to roboticslab-uc3m/speech that referenced this issue May 14, 2019
PeterBowman added a commit to asrob-uc3m/yarp-devices that referenced this issue May 14, 2019
PeterBowman added a commit to roboticslab-uc3m/openrave-yarp-plugins that referenced this issue May 14, 2019
PeterBowman added a commit to roboticslab-uc3m/vision that referenced this issue May 14, 2019
PeterBowman added a commit to asrob-uc3m/robotDevastation that referenced this issue May 14, 2019
PeterBowman added a commit to roboticslab-uc3m/kinematics-dynamics that referenced this issue May 15, 2019
@PeterBowman
Copy link
Member Author

Since latest YARP master is now recommended, and YARP 3.1 was released shortly after YARP 3.0, I'm probably going to require YARP 3.1+ in a few repos (namely kin-dyn, openrave-yarp-plugins and yarp-devices). This will spare several version checks regarding features that had been added in v3.1 but weren't present at v3.0.x.

PeterBowman added a commit to roboticslab-uc3m/yarp-devices that referenced this issue May 15, 2019
PeterBowman added a commit to roboticslab-uc3m/installation-guides that referenced this issue May 15, 2019
PeterBowman added a commit to roboticslab-uc3m/teo-openrave-models that referenced this issue May 16, 2019
@PeterBowman
Copy link
Member Author

PeterBowman commented May 18, 2019

  • Fix C++/CMake deprecation warnings (check Travis builds).

Notable changes:

  • yarp::os::ConstString -> std::string
  • yarp::os::RateThread -> yarp::os::PeriodicThread
    • setRate() -> setPeriod()
    • milliseconds -> seconds
  • VOCAB<N> -> yarp::os::createVocab() (YARP 3.1)
  • IPositionControl2 -> IPositionControl and so on
  • Arch-dependent addInt()-like methods (Properly handle 8,16,32,64 bit integers and 32,64 bit floating point values robotology/yarp#1677)
    grep -rnIP '(add|is|as|make)(Int|Double)' /path/to/src/root --exclude-dir={build,doc}
    find /path/to/src/root -type f -exec sed -i -r 's/(add|is|as|make)Int/\1Int32/g' {} \+
    find /path/to/src/root -type f -exec sed -i -r 's/(add|is|as|make)Double/\1Float64/g' {} \+
    
  • YARP_HAS_MATH_LIB -> YARP_math_FOUND (CMake code)

@PeterBowman
Copy link
Member Author

Tag the last pre-v3.0 commit.

Done at most relevant repositories listed here, namely:

Nothing more to do here, closing.

[ROBOTICSLAB] automation moved this from In progress to Done May 21, 2019
@PeterBowman PeterBowman unpinned this issue May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
[ROBOTICSLAB]
  
Done
Development

No branches or pull requests

2 participants