Add static assertion on param in cyclic synchronous tranmission type

roboticslab-uc3m · Jan 8, 2020 · 6bbfffc · 6bbfffc
1 parent 4f1ef7b
commit 6bbfffc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/libraries/CanBusSharerLib/PdoProtocol.hpp b/libraries/CanBusSharerLib/PdoProtocol.hpp
@@ -48,8 +48,13 @@ class PdoTransmissionType final
     { return type; }
 
     //! Cast input byte to an @ref PdoTransmissionType enumerator.
-    static constexpr PdoTransmissionType SYNCHRONOUS_CYCLIC_N(std::uint8_t n)
-    { return static_cast<transmission_type>(n); }
+    template<std::uint8_t n>
+    static constexpr PdoTransmissionType SYNCHRONOUS_CYCLIC_N()
+    {
+        // https://stackoverflow.com/a/12109644
+        static_assert(n >= 0x01 && n <= 0xF0, "Illegal argument."); // [1-240]
+        return static_cast<transmission_type>(n);
+    }
 
 private:
     transmission_type type = SYNCHRONOUS_ACYCLIC;

diff --git a/tests/testCanBusSharerLib.cpp b/tests/testCanBusSharerLib.cpp
@@ -591,7 +591,7 @@ TEST_F(CanBusSharerTest, TransmitPdo)
 
     const unsigned int n = 1;
 
-    PdoTransmissionType type = PdoTransmissionType::SYNCHRONOUS_CYCLIC_N(0x04);
+    PdoTransmissionType type = PdoTransmissionType::SYNCHRONOUS_CYCLIC_N<0x04>();
 
     const std::uint16_t comm = 0x1800 + n - 1;
     const std::uint8_t commLSB = comm & 0x00FF;