-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subt.drone: draw control inputs #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tool - I would postpone merge 24 hours, i.e. after Cave Circuit final submission just in case we may need some changes in master, OK?
#height = [(a[1], a[1] - a[2], a[1] + a[3], a[4]) for a in self.debug_arr] | ||
#line_obj = plt.plot(t, height, '-o', linewidth=2) | ||
#plt.legend(iter(line_obj), ('altitude', 'alt - bottom', 'alt + top', 'pose3D.z')) | ||
#plt.xlabel('time (s)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label would be nice (from the code I see that it is bottom_scan
count. Ideal would be simulated time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not that proficient with matplotlib and was in kind of a hurry.
a = [A for count, H, E, A in self.debug_arr2] | ||
e = [E for count, H, E, A in self.debug_arr2] | ||
h = [H for count, H, E, A in self.debug_arr2] | ||
plt.plot(x, a) | ||
plt.plot(x, e) | ||
plt.plot(x, h) | ||
plt.xlabel('sim time (s)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's approximation since the messages can be dropped out on the ROS side but I guess that does not really matter for this much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is misleading (the absolute time) - it can give us hint about period of the oscillations but as I was wondering why the mode changes at time 658s then the answer is that it is +/-100 because of initial simulation time offset. When things calms down I would add input also sim_time_sec
and compensate for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if that is the best solution. I am thinking about a bigger change that would involve adding "time" to a lot of messages we are sending in osgar which would say at which point of time was the data relevant (ie. for a sensor - when was the data measured etc).
Lets merge this and continue with #698 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -72,6 +72,7 @@ def main(): | |||
format='%(name)-12s %(levelname)-8s %(message)s', | |||
#datefmt='%Y-%m-%d %H:%M', | |||
) | |||
logging.getLogger("matplotlib").setLevel(logging.INFO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if there is not logger for matplotlib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is created
No description provided.