Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YARP portmonitor initialization #292

Closed
pattacini opened this issue Apr 20, 2021 · 5 comments · Fixed by #293
Closed

Update YARP portmonitor initialization #292

pattacini opened this issue Apr 20, 2021 · 5 comments · Fixed by #293
Assignees
Labels
📝 assignment Task unrelated to code development

Comments

@pattacini
Copy link
Member

Hi @vvasco

The breaking changes introduced in robotology/yarp#2552 will have an impact on our codebase.
For example, look at the following:

<protocol>fast_tcp+send.portmonitor+file.zfp+recv.portmonitor+file.zfp+type.dll</protocol>

Would you be willing to take care of this update?

@pattacini pattacini added the 📝 assignment Task unrelated to code development label Apr 20, 2021
@vvasco
Copy link

vvasco commented Apr 21, 2021

Hi @pattacini, I did the changes in the branch fix/portmonitor-names.

@pattacini
Copy link
Member Author

Fantastic! When the change will land in yarp@master we'll open up the internal PR.

@randaz81
Copy link
Member

Hi! After this reorganization, I am adding a couple of new portmonitors. Since you are already using zfp (lossy depth compression), I just wanted to tell you that a new pm, based on zlib, will be available, for lossless depth compression. The name will be depthimage_compression_zlib. Stay tuned ;-)

@pattacini
Copy link
Member Author

Thanks @randaz81 for letting us know 👍🏻
I think we can already fix the pm strings after the merge of the PR in YARP while keeping an eye wide open on your current development.

@pattacini
Copy link
Member Author

This is the PR @randaz81 was referring to: robotology/yarp#2553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 assignment Task unrelated to code development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants