Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize portmonitors #2552

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Apr 20, 2021

PortMonitors

  • Portmonitors were reorganized and renamed without keeping the back
    compatibility with the old name.
    The new names are:
    • depthimage_compression_zfp (zfp)
    • depthimage_to_mono (depthimage)
    • depthimage_to_rgb (depthimage2)
    • segmentationimage_to_rgb (segmentationimage)
      The new names for portmonitors not released yet are:
    • image_compression_ffmpeg (libffmpeg)
    • sound_compression_mp3 (mp3Sound)
  • There is now a new yarppm library (similar to yarpcar and yarpmod) that
    links all the portmonitors in static builds.

⚠️ This is a breaking change, but keeping compatibility would be quite complex compared to updating the connection string when you notice that the connection fails...

@drdanz drdanz added Component: Carriers Type: Cleanup Involves cleaning up some part of YARP Type: Breaking/Behaviour Change Involves breaking user code or behaviour Target: YARP v3.5.0 Component: Port Monitors labels Apr 20, 2021
@drdanz drdanz self-assigned this Apr 20, 2021
@drdanz drdanz requested a review from Nicogene as a code owner April 20, 2021 18:59
@drdanz drdanz added this to In progress in YARP v3.5.0 (2021-07-15) via automation Apr 20, 2021
@drdanz drdanz requested review from randaz81 and removed request for Nicogene April 20, 2021 19:00
Portmonitors were reorganized and renamed without keeping the back
compatibility with the old name.
The new names are:
* `depthimage_compression_zfp` (`zfp`)
* `depthimage_to_mono` (`depthimage`)
* `depthimage_to_rgb` (`depthimage2`)
* `segmentationimage_to_rgb` (`segmentationimage`)
The new names for portmonitors not released yet are:
* `image_compression_ffmpeg` (`libffmpeg`)
* `sound_compression_mp3` (`mp3Sound`)

There is now a new library (similar to yarpcar and yarpmod) that links all the
portmonitors in static builds.
@drdanz drdanz temporarily deployed to code-analysis April 20, 2021 19:08 Inactive
@drdanz drdanz temporarily deployed to code-analysis April 20, 2021 19:08 Inactive
vvasco pushed a commit to robotology/assistive-rehab that referenced this pull request Apr 21, 2021
@randaz81 randaz81 merged commit e886a09 into robotology:master Apr 22, 2021
YARP v3.5.0 (2021-07-15) automation moved this from In progress to Done Apr 22, 2021
@drdanz drdanz deleted the portmonitor_rename branch April 22, 2021 09:15
pattacini added a commit to robotology/assistive-rehab that referenced this pull request Apr 22, 2021
Co-authored-by: Valentina Vasco <valentina.vasco@iit.it>
traversaro added a commit to robotology/robotology-superbuild that referenced this pull request Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants