Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce an underlying structure of the skeletons #33

Closed
pattacini opened this issue Apr 13, 2018 · 3 comments
Closed

Enforce an underlying structure of the skeletons #33

pattacini opened this issue Apr 13, 2018 · 3 comments
Assignees
Labels
🚀 enhancement New feature or request

Comments

@pattacini
Copy link
Member

pattacini commented Apr 13, 2018

By resorting to optimization, we might enforce the following skeleton's structure:

  • left and right upper/lower arms and upper/lower legs need to have the same length
  • the angle among some limbs do have bounded ranges
@pattacini pattacini added the 🚀 enhancement New feature or request label Apr 13, 2018
@pattacini pattacini added this to the Demo Y1M5 milestone Apr 13, 2018
@pattacini pattacini self-assigned this Apr 13, 2018
@pattacini pattacini changed the title Final improvement to skeletonRetriever Final improvements to skeletonRetriever Apr 14, 2018
@pattacini pattacini added the 💡 idea An idea to bear in mind label Apr 14, 2018
@pattacini pattacini removed this from the Demo Y1M5 milestone Apr 16, 2018
@pattacini pattacini removed the 💡 idea An idea to bear in mind label Apr 20, 2018
@pattacini
Copy link
Member Author

From 02be274 the code to optimize skeletons limbs is available. To enable this feature, turn true the flag optimize-limblength of the skeletonRetriever.

The implementation of the constant Hessian is still missing.

Finally, given that as it is openPose can provide only keypoints and segments and cannot discriminate any rotation of e.g. the shoulder yaw, it is not feasible at the moment to enforce the right sign among the limb angles.

@pattacini
Copy link
Member Author

@vvasco I've just made a few quick tests and the optimization is working nicely.
Thereby, the optimization is now on by default since 4cc949b.

@pattacini pattacini added this to the Demo Y1M5 milestone Apr 20, 2018
@pattacini pattacini changed the title Final improvements to skeletonRetriever Enforce an underlying structure for the skeletons Apr 20, 2018
@pattacini pattacini changed the title Enforce an underlying structure for the skeletons Enforce an underlying structure of the skeletons Apr 20, 2018
@pattacini
Copy link
Member Author

pattacini commented Apr 20, 2018

#39 finalized this development.

Original
original
Optimized
optimized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant