Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated interactionManager for the new demo #94

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Updated interactionManager for the new demo #94

merged 2 commits into from
Sep 10, 2018

Conversation

vvasco
Copy link

@vvasco vvasco commented Sep 10, 2018

The interactionManager is no longer in charge of the evaluation of the quality of the movement.
When the person is engaged and the exercise starts, it waits until the exercise is over.
Meanwhile, the feedbackSynthetizer provides the verbal feedback during the exercise.

@vvasco vvasco added the ✨improvement Improve current features label Sep 10, 2018
@vvasco vvasco added this to the Y1Q3 milestone Sep 10, 2018
@vvasco vvasco self-assigned this Sep 10, 2018
pattacini
pattacini requested changes Sep 10, 2018
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't keep stale code commented.
We can always retrieve it back from git.

@pattacini pattacini merged commit 27df04b into master Sep 10, 2018
@pattacini pattacini deleted the update-interaction branch September 10, 2018 12:26
@pattacini pattacini mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

Assignees

@vvasco vvasco

Labels
✨improvement Improve current features
Projects
None yet
Milestone
Y1Q3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vvasco @pattacini