Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore feature parity of C++ and Python robot interfaces #65

Closed
3 tasks
diegoferigo opened this issue Oct 9, 2019 · 1 comment
Closed
3 tasks

Restore feature parity of C++ and Python robot interfaces #65

diegoferigo opened this issue Oct 9, 2019 · 1 comment

Comments

@diegoferigo
Copy link
Member

diegoferigo commented Oct 9, 2019

Due to a different pace of development and different requirements, the Python robot interfaces are now much more complete than the C++ interfaces.

As a reference, compare:

Ignition Gazebo still does not have all the components (in the sense of its ECM) to support all the features we defined in #33. Though, at least having the links and the base frame interfaces would be a positive move to start simulating floating-base robots.

Finalizing this task might be the right occasion to open an upstream PR in ign-gazebo proposing the inclusion of the missing components.


  • Links
  • Contacts
  • Base Frame
@diegoferigo
Copy link
Member Author

The Robot Python class has been removed and replaced by a much improved SWIG interfacing of the new ScenarI/O bindings.

We managed to strip the extra Python layer of the Robot classes, at the cost that now new physics engines can only be implemented as ignition physics plugins. While this could be more difficult, it has the big advantage that we don't have to modify anything from the gym-ignition side and maintaining multiple engines becomes trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment