Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old configuration files - presumably not used #185

Closed
xEnVrE opened this issue Feb 14, 2023 · 3 comments · Fixed by robotology/icub-models-generator#236
Closed

Old configuration files - presumably not used #185

xEnVrE opened this issue Feb 14, 2023 · 3 comments · Fixed by robotology/icub-models-generator#236

Comments

@xEnVrE
Copy link
Contributor

xEnVrE commented Feb 14, 2023

While I was working on #171 (comment), I noticed that there are several files inside https://github.com/robotology/icub-models/tree/devel/iCub/conf, where ideally only automatically generated file should stay, that are not updated by the GitHub action.

I am wondering whether these are really used by some of the automatically generated models or not. As an example, I think that automatically generated models are using the file:

while the repository still hosts:

having their last commit 3 years ago and still using the controlboardwrapper2.

Other files are probably not required anymore:

Should we think of removing these files in order to tidy up the configuration folder?

@traversaro
Copy link
Member

Thanks for opening this issue!

To avoid having this problem again, we should delete everytime all the files in the directory of automatically generated files.

@traversaro
Copy link
Member

Ok, I started tackling this with:

Once this are done, we need to actually delete the files.

@xEnVrE
Copy link
Contributor Author

xEnVrE commented Feb 14, 2023

Once this are done, we need to actually delete the files.

Ok, meanwhile I am tackling #171 so that the manually edited robot, at least iCubGazeboV2_5_visuomanip, will only use the manually generated configuration files and, newly introduced, wrappers for the yarprobotinterface plus some of the automatically generated configuration files (those that are actually used by all the other simulated robots and can be shared).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants