Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation of matlab bindings should use the matlab_add_mex CMake function #228

Open
traversaro opened this issue Sep 9, 2016 · 2 comments

Comments

@traversaro
Copy link
Member

We had problems related to that in getting the bindings to work in Windows.

@traversaro
Copy link
Member Author

We would avoid to manually do this like this: ab0ecc4 .

@traversaro
Copy link
Member Author

This could also avoid symbols clash between system libraries and matlab libraries (as this one: robotology-legacy/codyco-superbuild#141), see this comment in FindMatlab.cmake ,

# if we do not do that, the symbols linked from eg. boost remain weak and
:

   # if we do not do that, the symbols linked from eg. boost remain weak and
   # then clash with the ones defined in the matlab process. So by default
   # the symbols are hidden.
   # This also means that for shared libraries (like MEX), the entry point
   # should be explicitly declared with default visibility, otherwise Matlab
   # cannot find the entry point.
   # Note that this is particularly meaningful if the MEX wrapper itself 
   # contains symbols that are clashing with Matlab (that are compiled in the
   # MEX file). In order to propagate the visibility options to the libraries 
   # to which the MEX file is linked against, the -Wl,--exclude-libs,ALL
  # option should also be specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant