Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug test issue on windows #78

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Fix debug test issue on windows #78

merged 3 commits into from
Oct 3, 2017

Conversation

aerydna
Copy link
Contributor

@aerydna aerydna commented Oct 3, 2017

fix #75

@Nicogene Nicogene self-requested a review October 3, 2017 12:34
Nicogene
Nicogene requested changes Oct 3, 2017
View reviewed changes
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog 👿

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited

Coverage Status

Coverage increased (+1.05%) to 60.513% when pulling 198d173 on fixDebugTestIssueOnWindows into dbca3a4 on devel.

Nicogene
Nicogene approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Oct 3, 2017 •
edited

Coverage Status

Coverage increased (+1.05%) to 60.513% when pulling 1f85d22 on fixDebugTestIssueOnWindows into c6b97f2 on devel.

@aerydna aerydna merged commit 10d4603 into devel Oct 3, 2017
@aerydna aerydna mentioned this pull request Oct 3, 2017
Closed
@aerydna aerydna deleted the fixDebugTestIssueOnWindows branch October 4, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aerydna @coveralls @Nicogene @drdanz