Invert logic of RTF_*_IF macros #84
Conversation
|
@damn1 I changed the PR to target |
src/rtf/include/rtf/TestAssert.h
Outdated
| * test failed. | ||
| */ | ||
| #define RTF_ASSERT_FAIL_IF(condition, message) \ | ||
| RTF_TEST_REPORT("WARNING: RTF_ASSERT_FAIL_IF(condition, message) "\ |
There was a problem hiding this comment.
It would be ideal if we could turn this in a compilation warning rather than a runtime warning. Let me know if it is not possible, in that case I will approve the PR as it is. : )
|
@damn1 check the output of AppVeyor, it seems that the errors are failing for some reason. |
doc/release/v1_4_0.md
Outdated
| @@ -11,6 +11,9 @@ Important Changes | |||
| * Fixed old typo, the keyword `suit` has been | |||
| replaced with `suite`, maintaining the backward | |||
| compatibility. | |||
| * Change logic for RTF_*_IF(condition, message) | |||
| functions, adding new functions RTF_*_IF_TRUE | |||
| and RTF_*_IF_FALSE, deprecating the old ones | |||
There was a problem hiding this comment.
The Markdown of this comment is not rendering correctly. I suspect you should make sure that the asterisk is not interpreted as the beginning of an italic sentence, for example using back-ticks: not good, *good*.
There was a problem hiding this comment.
Furthermore, do not forget the point at the end of the sentence.
src/rtf/include/rtf/TestAssert.h
Outdated
| */ | ||
| #define RTF_ASSERT_FAIL_IF(condition, message) \ | ||
| RTF_TEST_REPORT("WARNING: RTF_ASSERT_FAIL_IF(condition, message) "\ | ||
| "is deprecated and will be removed. Substitue with "\ |
There was a problem hiding this comment.
Typo: "Substitue --> substitute" . Furthermore, it is always nice to be kind to strangers: I would go for "Please substitute". : )
src/rtf/include/rtf/TestAssert.h
Outdated
| */ | ||
| #define RTF_ASSERT_ERROR_IF(condition, message)\ | ||
| RTF_TEST_REPORT("WARNING: RTF_ASSERT_ERROR_IF(condition, message) "\ | ||
| "is deprecated and will be removed. Substitue with "\ |
There was a problem hiding this comment.
damn1
force-pushed
the
rtf_testfaillogic
branch
from
3e465f0
to
c81b05e
Compare
1 similar comment
damn1
force-pushed
the
rtf_testfaillogic
branch
3 times, most recently
from
cd95923
to
e4bd106
Compare
…unctions ad deprecating the old ones
damn1
force-pushed
the
rtf_testfaillogic
branch
from
e4bd106
to
c0d2216
Compare
1 similar comment
|
merged, thanks! |
Change logic for RTF_dosomething_IF(condition, message) macros, adding new macros RTF_dosomething_IF_TRUE and RTF_dosomething_IF_FALSE, deprecating the old ones with a warning message.