Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the step adaptation feature #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MiladShafiee
Copy link

changing the name of QPSolver class

remove small bug

combining the two class of step adaptation into one class

small modifications of step adaptation library

modifications of step adaptation library

modifications of step adaptation library

small modifications of step adaptation library

removing some useless methods

removing some useless methods

small modifications

adding an enum for recognizing of swing foot in solve method

Using step adaptation library inside the walking controller

fixing some bugs

fixing the bug related to the size of hessian matrix of step adaptation optimization

push recovery by two arms in saggital and lateral direction

cleaning the code

some primary modifications

separation of the step adaptation config files

some primary modifications

adding the documentation link to the simple estimator

modification of the configuration file

make an object of TrajectoryGeneration for step adjustment

some modifications in trajectoryGenerator and module

some small modifications in Module.cpp

moving the arms push detection inside the stepAdjustment module

modifying some comments

dubeg of moving the step adjustment stuff from walkingModule to step adaptation library

Keeping the dcm replanning part inside the walkingModule

remove some magic numbers

modify the input of runstepAdaptation as a reference

small modifications

step adaptation documentation and configuration files modification

Bring the arm joints name for push detection inside the configuration file

some modification on walkingModule and exceptions

some modifications in walkingModule

defining the output and input of step adaptation structure as a private member

removing some small bugs!

add missing trajectoryPlanner inside cmake lists

remove the bug related to zmp offset

copy the retargeting planner parameters to reduce the shaking

tuning pull request on the robot

step adaptation left arm lateral direction

tuning the planner parametr for yaw movement

tuning unicycle planner parameter for rotational movement

tuning step adaptaion on the robot

set stiffness and damping joint again inside the code

tune the step adaptation parameters

tuning step adaptation

tuning step adjustment

tune the step adaptation parameters

activating push recovery every two steps

lateral direction is working

remove the yaw error

remove some comments

tuning step adaptaion parameters

remove the bug related to the yaw orientation

small modification

removing the bug related to the push detection during rotational walking

parameter tuning

some small modifications

solve the problem of joystick command during step adaptation

solve the problem of joystick

increasing speed of walking

some modifications

try to solve joystick problem

small modification

try to solve the last step impact

saturation of the com error

tunning parameters

saturation of the com error

video recorded version

pull request modifications

Fix some rebase issues.

@MiladShafiee
Copy link
Author

After rebasing I can not run walkingModule when we use the step adaptation configuration files:
We have these errors:

[ERROR][getiDynTreeVectorFixSizeFromSearchable] Missing field  good_tracking_required 
[ERROR][RobotInterface::configureRobot] Unable to find is_good_tracking_required into config file. 
[ERROR][WalkingModule::configure] Unable to configure the robot.

@S-Dafarra
Copy link
Collaborator

After rebasing I can not run walkingModule when we use the step adaptation configuration files:
We have these errors:
[ERROR][getiDynTreeVectorFixSizeFromSearchable] Missing field good_tracking_required
[ERROR][RobotInterface::configureRobot] Unable to find is_good_tracking_required into config file.
[ERROR][WalkingModule::configure] Unable to configure the robot.

It means that some fields are not present in the corresponding configuration files. Probably we missed this while rebasing.

@MiladShafiee
Copy link
Author

It means that some fields are not present in the corresponding configuration files. Probably we missed this while rebasing.

Yeah I added the missing parts and now the problem is that seems does not load the stiffness and damping gains!

@S-Dafarra
Copy link
Collaborator

It means that some fields are not present in the corresponding configuration files. Probably we missed this while rebasing.

Yeah I added the missing parts and now the problem is that seems does not load the stiffness and damping gains!

Unfortunately, that part was a little tricky to rebase. You can still check with the old version of the code if something is missing.

@S-Dafarra
Copy link
Collaborator

S-Dafarra commented Jul 22, 2020

With @MiladShafiee we tested this version on the robot. It was not working out-of-the-box. Nevertheless, we noticed that the devel version was not working either. After some trials, I managed to find the difference that prevented it to work, i.e. https://github.com/robotology/walking-controllers/compare/feature/stepAdaptation...debug/feature/stepAdaptation?expand=1

Milad and others added 2 commits September 18, 2020 11:51
changing the name of QPSolver class

remove small bug

combining the two class of step adaptation into one class

small  modifications of step adaptation library

modifications of step adaptation library

modifications of step adaptation library

small modifications of step adaptation library

removing some useless methods

removing some useless methods

small modifications

adding an enum for recognizing of swing foot in solve method

Using  step adaptation library inside the walking controller

fixing some bugs

 fixing  the bug related to the  size of hessian matrix of step adaptation optimization

push recovery by two arms in saggital and lateral direction

cleaning the code

some primary modifications

separation of the step adaptation config files

some primary modifications

adding the documentation link to the simple estimator

modification of the configuration file

make an object of TrajectoryGeneration for step adjustment

some modifications in trajectoryGenerator and module

some small modifications in Module.cpp

moving the arms push detection inside the stepAdjustment module

modifying some comments

dubeg of moving the step adjustment stuff from walkingModule to step adaptation library

Keeping  the dcm replanning part inside the walkingModule

remove some magic numbers

modify the input of runstepAdaptation as a reference

small modifications

step adaptation documentation and configuration files modification

Bring the arm joints name for  push detection inside the configuration file

some modification on walkingModule and exceptions

some modifications in walkingModule

defining  the output and input of step adaptation structure as a private member

removing some small bugs!

 add missing trajectoryPlanner inside cmake lists

remove the bug related to zmp offset

copy  the retargeting planner parameters to reduce the  shaking

tuning pull request on the robot

step adaptation left arm lateral direction

tuning the planner parametr for yaw movement

tuning unicycle planner parameter for rotational movement

tuning step adaptaion on the robot

set stiffness and damping joint again inside the code

tune the step adaptation parameters

 tuning step adaptation

 tuning step adjustment

tune the step adaptation parameters

activating push recovery every two steps

lateral direction is working

remove the yaw error

remove some comments

tuning step adaptaion parameters

remove the bug related to the yaw orientation

small modification

removing the bug related to the push detection during rotational walking

parameter tuning

some small modifications

solve the problem of joystick command during step adaptation

solve the problem of joystick

increasing speed of walking

some modifications

try to solve joystick problem

small modification

try to solve the last step impact

saturation of the com error

tunning parameters

saturation of the com error

video recorded version

pull request modifications

Fix some rebase issues.
@S-Dafarra
Copy link
Collaborator

Rebased on top of devel after #68

@S-Dafarra S-Dafarra removed this from the Iteration 51 - Back to school milestone Oct 22, 2020
@S-Dafarra S-Dafarra changed the base branch from devel to master May 27, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants