InstallBasicPackageFiles: change default for NO_SET_AND_CHECK_MACRO and NO_CHECK_REQUIRED_COMPONENTS_MACRO

[drdanz]

At the moment the NO_SET_AND_CHECK_MACRO and NO_CHECK_REQUIRED_COMPONENTS_MACRO can be used to disable some parts of code generated by configure_package_config_file.
For the basic install_basic_package_file usage, these parts of code are not useful though, and therefore these options are set in most of the cases.

I'd like to deprecate these 2 options, and pass them by default to configure_package_config_file.

We could add the ENABLE_SET_AND_CHECK_MACRO and ENABLE_CHECK_REQUIRED_COMPONENTS_MACRO options instead.

Anyway, this would be a small breaking change if someone is actually relying on these macros, so perhaps we can parse the Config.cmake file, and check if these macros are used, and eventually enable it. If this works, we could simply forgot about the option, and just parse the files, and enable whatever is used.

What do you think?

[PeterBowman]

Anyway, this would be a small breaking change if someone is actually relying on these macros, so perhaps we can parse the Config.cmake file, and check if these macros are used, and eventually enable it. If this works, we could simply forgot about the option, and just parse the files, and enable whatever is used.

Corner case: the config file include()s a file in which set_and_check() is used.

[drdanz]

@PeterBowman I've never seen it, but I assume it is possible... So perhaps we could have the detection, but also the FORCE_SET_AND_CHECK_MACRO and FORCE_CHECK_REQUIRED_COMPONENTS_MACRO options to skip the detection and just add it...