Fix that space glyph's unicodes could be empty #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying
extractUFO
to a TTF with vmtx, such as a CJK font, may result in an empty list of unicodes for the space glyph.According to the OpenType specification, VORG is a CFF OpenType specific table, so the path for measuring the bounding box using
ControlBoundsPen
will be performed inextractOpenTypeGlyphs
. In the case of the space glyph, the bounding box isNone
, so we have tocontinue
before setting the unicodes. However, this does not seem to be the correct behavior.To reproduce the problem you can use for example the following font:
https://github.com/fontworks-fonts/Reggae/blob/master/fonts/ttf/ReggaeOne-Regular.ttf