Type1 macroman #53
Merged
Type1 macroman #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fontographer had macroman as default. + simplify glyphOrder extractor: python 3 dict keys are ordered
Lib/extractor/formats/type1.py
Outdated
| source = T1Font(pathOrFile, encoding="ascii") | ||
| source["FontInfo"] | ||
| except UnicodeDecodeError: | ||
| source = T1Font(pathOrFile, encoding="macroman") |
There was a problem hiding this comment.
What do you gain by first trying with ascii? It is a subset of macroman anyway, so there's zero difference in behavior with just using macroman straight away.
There was a problem hiding this comment.
true, fixed "macroman" it is
should we change the default encoding to macroman in fontTools' |
Perhaps, yes. Not sure why I didn't do so back when I wrote fonttools/fonttools#1234... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve by trying to read ascii, if that fails read the fontfile with macroman encoding.
Fontographer had macroman as default.