Ramsetecommand implemented with Overtake and Beartype #42
Conversation
…re tests to check for correct argument parsing in constructor
|
Are these failures because overtake and beartype aren't available? I based this branch from the previously successful PR where all the ci/test cases pass. I did need to separately install overtake and beartype with pip but it does work on my machine. |
|
If you're modifying the package to require packages to be installed, you would need to modify the requirements in setup.py to ensure that they get installed. Edit: oh, you did. Hm. |
| self._prevSpeeds = DifferentialDriveWheelSpeeds() | ||
| self._prevTime = -1.0 | ||
| self.usePID = True | ||
| # All the parameter checks pass, inform scheduler. Type ignoring is set explictitly for the linter because this |
There was a problem hiding this comment.
... I don't understand this comment? Shouldn't you unpack here?
There was a problem hiding this comment.
When I keep things as they are with other commands, the '*' throws off the dispatch to the point where incorrect constructors get called, as well as mypy coming up with type errors. Basically, for me to get it to work, I had to declare the requirements explicitly as a Tuple, without unpacking since that's what addRequirements wants. Mypy was not happy with this solution, so I just type:ignore.
There is possibly a way to get it to work, but I couldn't figure it out.
No description provided.