-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing command framework pieces #28
Comments
CommandGenericHID does not inherit from GenericHID, which breaks JoystickButton (expects a getRawButton function to exist). |
virtuald
added a commit
to robotpy/examples
that referenced
this issue
Nov 5, 2023
- Some of the command based examples don't work because the command framework is incomplete. See robotpy/robotpy-commands-v2#28
virtuald
added a commit
to robotpy/examples
that referenced
this issue
Nov 5, 2023
- Some of the command based examples don't work because the command framework is incomplete. See robotpy/robotpy-commands-v2#28
virtuald
added a commit
to robotpy/examples
that referenced
this issue
Nov 5, 2023
- Some of the command based examples don't work because the command framework is incomplete. See robotpy/robotpy-commands-v2#28
virtuald
added a commit
to robotpy/examples
that referenced
this issue
Nov 5, 2023
- Some of the command based examples don't work because the command framework is incomplete. See robotpy/robotpy-commands-v2#28
virtuald
added a commit
to robotpy/examples
that referenced
this issue
Nov 5, 2023
- Some of the command based examples don't work because the command framework is incomplete. See robotpy/robotpy-commands-v2#28
I think that's on purpose. The java one doesn't inherit either |
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 5, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 5, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 5, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 6, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 6, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 6, 2023
This was referenced Dec 6, 2023
virtuald
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 8, 2023
lospugs
pushed a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Dec 28, 2023
virtuald
added a commit
to lospugs/robotpy-commands-v2
that referenced
this issue
Jan 24, 2024
* robotpy#28 Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have moved to a pure python command framework for 2024, but it is currently incomplete. Here are the pieces I'm aware of that aren't implemented yet -- though I'm sure there's more.
There are probably more pieces too. I believe there are WPILib updates too.
Ideally PRs that include these features will also include tests ported from allwpilib's java implementation. I've had good success pasting in Java code into ChatGPT and asking it to convert it to Python, and there are other ways to do this also.
The text was updated successfully, but these errors were encountered: