Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(goreleaser): fix name_template #123

Merged

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Feb 13, 2024

name_template was updated by #108 but the update included a bug.
The bug changed the asset names.

https://github.com/robscott/kube-capacity/releases/tag/v0.8.0-rc1

image

"amd64" weren't replaced with "x86_64".

Test

I ran GoReleaser on my laptop and confirmed the issue was solved.

$ goreleaser -v     
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    1.24.0
GitCommit:     00c2ff733758f63201811c337f8d043e8fcc9d58
GitTreeState:  false
BuildDate:     2024-02-05T12:18:01Z
BuiltBy:       goreleaser
GoVersion:     go1.21.6
Compiler:      gc
ModuleSum:     h1:jsoS5T2CvPKOyECPATAo8hCvUaX8ok4iAq9m5Zyl1L0=
Platform:      darwin/arm64
$ goreleaser release --clean --snapshot                      
  • starting release...
  • loading                                          path=.goreleaser.yml
  • skipping announce, publish and validate...
  • loading environment variables
  • getting and validating git state
    • git state                                      commit=752ea69c9af562d7e692ae180af73b986855838a branch=main current_tag=v0.8.0-rc1 previous_tag=v0.7.4-rc7 dirty=true
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
    • DEPRECATED:  brews.tap  should not be used anymore, check https://goreleaser.com/deprecations#brewstap for more info
  • snapshotting
    • building snapshot...                           version=v0.8.0-rc1-next
  • checking distribution directory
    • cleaning dist
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/kube-capacity_windows_386/kube-capacity.exe
    • building                                       binary=dist/kube-capacity_linux_arm64/kube-capacity
    • building                                       binary=dist/kube-capacity_linux_386/kube-capacity
    • building                                       binary=dist/kube-capacity_windows_arm64/kube-capacity.exe
    • building                                       binary=dist/kube-capacity_darwin_arm64/kube-capacity
    • building                                       binary=dist/kube-capacity_darwin_amd64_v1/kube-capacity
    • building                                       binary=dist/kube-capacity_linux_amd64_v1/kube-capacity
    • building                                       binary=dist/kube-capacity_windows_amd64_v1/kube-capacity.exe
    • took: 3s
  • archives
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_windows_arm64.zip
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_linux_x86_64.tar.gz
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_windows_i386.zip
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_darwin_arm64.tar.gz
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_linux_i386.tar.gz
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_darwin_x86_64.tar.gz
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_windows_x86_64.zip
    • creating                                       archive=dist/kube-capacity_v0.8.0-rc1_linux_arm64.tar.gz
    • took: 3s
  • calculating checksums
  • homebrew tap formula
    • guessing install                               install=[bin.install "kube-capacity"]
    • guessing install                               install=[bin.install "kube-capacity"]
    • guessing install                               install=[bin.install "kube-capacity"]
    • guessing install                               install=[bin.install "kube-capacity"]
    • writing                                        formula=dist/homebrew/Formula/kube-capacity.rb
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • you are using deprecated options, check the output above for details
  • release succeeded after 6s
  • thanks for using goreleaser!
$ ls -1 dist 
artifacts.json
checksums.txt
config.yaml
homebrew
kube-capacity_darwin_amd64_v1
kube-capacity_darwin_arm64
kube-capacity_linux_386
kube-capacity_linux_amd64_v1
kube-capacity_linux_arm64
kube-capacity_v0.8.0-rc1_darwin_arm64.tar.gz
kube-capacity_v0.8.0-rc1_darwin_x86_64.tar.gz
kube-capacity_v0.8.0-rc1_linux_arm64.tar.gz
kube-capacity_v0.8.0-rc1_linux_i386.tar.gz
kube-capacity_v0.8.0-rc1_linux_x86_64.tar.gz
kube-capacity_v0.8.0-rc1_windows_arm64.zip
kube-capacity_v0.8.0-rc1_windows_i386.zip
kube-capacity_v0.8.0-rc1_windows_x86_64.zip
kube-capacity_windows_386
kube-capacity_windows_amd64_v1
kube-capacity_windows_arm64
metadata.json

name_template was updated by #108 but the update included a bug.
The bug changed the asset names.

https://github.com/robscott/kube-capacity/releases/tag/v0.8.0-rc1

"amd64" weren't replaced with "x86_64".
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review February 13, 2024 11:38
@robscott
Copy link
Owner

Thanks for all the details and the quick fix @suzuki-shunsuke!

@robscott robscott merged commit eb393e1 into robscott:main Feb 16, 2024
3 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the fix-goreleaser-name_template branch February 16, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants