Fix goreleaser error and update README with --no-taint flag #108
Conversation
Goreleaser depricated archives.replacements on 2023-06-06 (v1.19.0). Replacement config provided by goreleaser "Deprication notices" page on goreleaser.com
Updating doc to reflect work done on commit a68c7d4871db91edf7f7dbd69ee273cbbc8181af1
| @@ -146,6 +146,7 @@ kube-capacity --pods --containers --util --output yaml | |||
| --kubeconfig string kubeconfig file to use for Kubernetes config | |||
| -n, --namespace string only include pods from this namespace | |||
| --namespace-labels string labels to filter namespaces with | |||
| --no-taint exclude nodes with taints | |||
There was a problem hiding this comment.
I don't think this PR has merged yet (#98). Mind leaving this change out until I can figure out how to handle that PR and/or maybe just rebase it myself?
There was a problem hiding this comment.
the --no-taint flag was added in this commit. PR #101
Flag is initialized here. You can see it on main currently with -h.
Apologies I shouldn't have linked issue #91 because as you pointed out that has open PR #98 which is related to excluding specific taints.
There was a problem hiding this comment.
🤦 you're completely right, thanks!
If you're interested in taking a more active role in this project, I could definitely use some help, feel free to ping me on k8s Slack if interested and we can figure out the details. |
name_template was updated by #108 but the update included a bug. The bug changed the asset names. https://github.com/robscott/kube-capacity/releases/tag/v0.8.0-rc1 "amd64" weren't replaced with "x86_64".
Hello. Very cool project! I am new to open source and would love to get involved.
Goreleaser published the deprecation of archives.replacements here
The solution is to include the replacement in the name_template.
I was able to get the goreleaser working locally with this change.
Doc update is related to #91