Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#577 move FeatureExtractor to logic #597

Merged
merged 2 commits into from
Oct 3, 2020

Conversation

robstoll
Copy link
Owner

@robstoll robstoll commented Oct 2, 2020


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

- including FeatureExtractorBuilder
- use FeatureExpectOptions instead of own FeatureOptions
- move OptionsChooser to core and rename to FeatureExpectOptionsChooser
- adapt API accordingly, use FeatureExtractorBuilder.ExecutionStep
  instead of ExtractedFeaturePostStep
- rename AnyAssertions.notToBeNullBut to notToBeNullButOfType
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #597 into master will increase coverage by 0.06%.
The diff coverage is 96.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #597      +/-   ##
============================================
+ Coverage     86.01%   86.08%   +0.06%     
  Complexity       26       26              
============================================
  Files           904      908       +4     
  Lines          8230     8335     +105     
  Branches        367      367              
============================================
+ Hits           7079     7175      +96     
- Misses         1075     1084       +9     
  Partials         76       76              
Flag Coverage Δ Complexity Δ
#bbc 73.42% <94.17%> (+0.29%) 0.00 <0.00> (ø)
#bc 57.75% <67.46%> (+0.24%) 0.00 <0.00> (ø)
#current 57.68% <96.24%> (+0.55%) 130.00 <2.00> (+2.00)
#current_windows 48.61% <96.24%> (-0.90%) 130.00 <2.00> (+2.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...h/tutteli/atrium/api/fluent/en_GB/anyAssertions.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...teli/atrium/api/fluent/en_GB/iterableAssertions.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...ch/tutteli/atrium/api/infix/en_GB/anyAssertions.kt 66.66% <ø> (ø) 0.00 <0.00> (ø)
...tutteli/atrium/api/infix/en_GB/expectExtensions.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tteli/atrium/api/infix/en_GB/iterableAssertions.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...kotlin/ch/tutteli/atrium/creating/FeatureExpect.kt 66.66% <ø> (ø) 0.00 <0.00> (ø)
...ns/creators/impl/InAnyOrderOnlyAssertionCreator.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...rium/logic/creating/transformers/SubjectChanger.kt 66.66% <ø> (ø) 0.00 <0.00> (ø)
...rium/logic/impl/DefaultCollectionLikeAssertions.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...tutteli/atrium/logic/impl/DefaultListAssertions.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb85d21...f58b2ad. Read the comment docs.

@robstoll robstoll merged commit 5fc813d into master Oct 3, 2020
@robstoll robstoll deleted the #577-move-featureExtractor-to-logic branch October 3, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move FeatureExtractorBuilder from domain-builders to atrium-logic
1 participant