Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record start time and report it in albatross-client info #168

Closed
reynir opened this issue Dec 1, 2023 · 2 comments · Fixed by #169 or ocaml/opam-repository#26363
Closed

Record start time and report it in albatross-client info #168

reynir opened this issue Dec 1, 2023 · 2 comments · Fixed by #169 or ocaml/opam-repository#26363

Comments

@reynir
Copy link
Contributor

reynir commented Dec 1, 2023

This issue can arguably be solved by setting up proper monitoring.

With the option --restart-on-fail unikernels are restarted when they exit for example if they run out of memory. If you monitor closely the console output (albatross-client console my-unikernel) or if you have proper monitoring setup you can figure out when this happens. Otherwise this information is easily lost. It would be nice to have reported in albatross-client info the start time of the unikernel or how long it's been running.

@reynir
Copy link
Contributor Author

reynir commented Dec 1, 2023

Alternatively this information could be gathered using process info of the running solo5 tender.

@hannesm
Copy link
Collaborator

hannesm commented Dec 1, 2023

I agree that both "started at" and "restarted for N times" would be useful statistics and information in the info output.

The former is already present in the stats daemon (kinfo_mem.start -- afaict only available on FreeBSD) --> but I'm all up for taking a timestamp of when the process creation was done.

@reynir reynir linked a pull request Dec 4, 2023 that will close this issue
hannesm added a commit that referenced this issue Dec 4, 2023
* record start timestamp and provide via info (fixes #168)

* allow old clients to talk to new servers (they will send the old_unikernel_info2 and receive an old_unikernel_info)
hannesm added a commit to hannesm/opam-repository that referenced this issue Aug 15, 2024
CHANGES:

* BUGFIX install tls_endpoint as systemd service (not only as example), fix typo
  (robur-coop/albatross#183 @PizieDust)
* BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned
  integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm)
* BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm)
* BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm)
* FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm)
* FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm)
* BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir)
* BUGFIX update command: handle HTTP not found explicitly
  (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm)
* FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm)
* BUGFIX Albatross: store timestamp as generalized time instead of utc time
  (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility
   @PizieDust)
* BUGFIX FreeBSD: restart services when they terminate
  (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193)
* BUGFIX packaging: install albatross-client as albatross-client
  (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f)
* update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow)
* use ohex instead of hex (robur-coop/albatross#174 @hannesm)
* fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8,
  107c235eb94e83d6a077c42ee8b527c207af4ba7)
avsm pushed a commit to avsm/opam-repository that referenced this issue Sep 5, 2024
CHANGES:

* BUGFIX install tls_endpoint as systemd service (not only as example), fix typo
  (robur-coop/albatross#183 @PizieDust)
* BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned
  integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm)
* BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm)
* BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm)
* FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm)
* FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm)
* BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir)
* BUGFIX update command: handle HTTP not found explicitly
  (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm)
* FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm)
* BUGFIX Albatross: store timestamp as generalized time instead of utc time
  (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility
   @PizieDust)
* BUGFIX FreeBSD: restart services when they terminate
  (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193)
* BUGFIX packaging: install albatross-client as albatross-client
  (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f)
* update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow)
* use ohex instead of hex (robur-coop/albatross#174 @hannesm)
* fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8,
  107c235eb94e83d6a077c42ee8b527c207af4ba7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants