Improved typing #10
Merged
Improved typing #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify, I haven't done much testing. I recommend merging after the next release so we have time to find any issues due to messed up imports etc. |
arikalon1
reviewed
Jun 28, 2021
| @@ -20,7 +20,7 @@ def __init__(self, deploy_func, func, trigger_params, action_params=None): | |||
| self.trigger_params = trigger_params | |||
| self.action_params = action_params | |||
| self.playbook_id = playbook_hash(func, trigger_params, action_params) | |||
| if getattr(action_params, "pre_deploy_func", None) is not None: | |||
| if action_params is not None and getattr(action_params, "pre_deploy_func", None) is not None: | |||
There was a problem hiding this comment.
I'm not sure why we need this
There was a problem hiding this comment.
It was to make the type checker happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to see for now... I started playing around with some static type checkers and fixing the issues they found. Lets merge this into master soon-ish so the fixes don't have merge conflicts later on.