Log output when onError set (ampproject#34259)

rochapablo · Aug 30, 2021 · ead104a · ead104a
1 parent cf4eddc
commit ead104a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/build-system/tasks/check-types.js b/build-system/tasks/check-types.js
@@ -284,12 +284,17 @@ async function typeCheck(targetName) {
   }
 
   let errorMsg;
+  if (target.onError) {
+    // If an onError handler is defined, steal the output and let onError handle
+    // logging
+    opts.logger = (m) => (errorMsg = m);
+  }
+
   await closureCompile(entryPoints, './dist', `${targetName}-check-types.js`, {
     noAddDeps,
     include3pDirectories: !noAddDeps,
     includePolyfills: !noAddDeps,
     typeCheckOnly: true,
-    logger: (m) => (errorMsg = m),
     ...opts,
   }).catch((error) => {
     if (!target.onError) {