Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Better neuropil.separate tests #130

Merged
merged 6 commits into from
May 17, 2020

Conversation

scottclowe
Copy link
Member

Tests for neuropil now:

  • use subtest contexts
  • test running neuropil separation with different parameter sets
  • only test the convergence status of the result, and not the exact number of iterations

This fixes a test which was broken when scikit-learn moved from version 0.22.2.post1 to 0.23.0.

@scottclowe scottclowe force-pushed the tst_use-subtest branch 2 times, most recently from 97b5e83 to c7eea73 Compare May 17, 2020 19:22
and not to just test one iteration. The results of the previous
test were too stringent and changed when scikit-learn moved from
version 0.22.2.post1 to 0.23.0.
Their release is not compatible with the latest skimage==0.17.2.
@scottclowe scottclowe merged commit 2694532 into rochefort-lab:master May 17, 2020
@scottclowe scottclowe changed the title TST: Change npil tests TST: Better neuropil.separate tests May 17, 2020
@scottclowe scottclowe deleted the tst_use-subtest branch May 17, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant