REL: Release version 0.7.1 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not to just test one iteration. The results of the previous test were too stringent and changed when scikit-learn moved from version 0.22.2.post1 to 0.23.0.
All ROI types which possess x, y and n attributes are handled in the same way as a polygon ROI, constructing a polygon using the points supplied. ROI types "freehand", "freeline", "multipoint", "point", "polygon", "polyline", and "trace" are now handled correctly.
Co-ordinates in ImageJ have top at 0, so it should be bottom = top + height. Previously it was as if bottom was at 0, and the result was incorrect polygon y co-ordinates.
When we use `np.assert_all_close` using `self.assertEqual` as declared with `addTypeEqualityFunc`, it is passed a `msg` argument which `np.assert_all_close` doesn't accept. So we need to ferry this argument away.
For checking two dictionaries of numpy.ndarrays are the same.
This is when the rotation argument was added to skimage.draw.ellipse.
We don't deal with the potential superresolution in the pixel locations, and so the output is incorrect.
Their release is not compatible with the latest skimage==0.17.2.
Having problems pushing with the python script (installed via pip) and it seems like the big name python packages (numpy, pytest) tend to use the bash script instead, which is working for them.
Codecov Report
@@ Coverage Diff @@
## v0.7.x #136 +/- ##
===========================================
+ Coverage 80.40% 91.57% +11.17%
===========================================
Files 9 9
Lines 740 760 +20
Branches 139 142 +3
===========================================
+ Hits 595 696 +101
+ Misses 109 37 -72
+ Partials 36 27 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ships PRs #130, #132 and #135.
Fixed
Added