Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Push to codecov with bash script, not python script #132

Merged
merged 1 commit into from
May 18, 2020

Conversation

scottclowe
Copy link
Member

Having problems pushing with the python script (installed via pip)
and it seems like the big name python packages (numpy, pytest)
tend to use the bash script instead, which is working for them.

I took this more robust version of the download command from pytest https://github.com/pytest-dev/pytest/blob/864338de71d6b56f0029b8ea8f45581001e2bab1/scripts/report-coverage.sh

Having problems pushing with the python script (installed via pip)
and it seems like the big name python packages (numpy, pytest)
tend to use the bash script instead, which is working for them.
@scottclowe scottclowe added the ci label May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2694532). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage          ?   82.41%           
=========================================
  Files             ?        9           
  Lines             ?      745           
  Branches          ?      142           
=========================================
  Hits              ?      614           
  Misses            ?       99           
  Partials          ?       32           
Impacted Files Coverage Δ
fissa/datahandler.py 100.00% <0.00%> (ø)
fissa/deltaf.py 100.00% <0.00%> (ø)
fissa/__meta__.py 100.00% <0.00%> (ø)
fissa/roitools.py 89.07% <0.00%> (ø)
fissa/datahandler_framebyframe.py 100.00% <0.00%> (ø)
fissa/ROI.py 78.72% <0.00%> (ø)
fissa/readimagejrois.py 51.14% <0.00%> (ø)
fissa/neuropil.py 86.84% <0.00%> (ø)
fissa/core.py 94.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2694532...e363fe9. Read the comment docs.

@scottclowe scottclowe merged commit a8f0066 into rochefort-lab:master May 18, 2020
@scottclowe scottclowe deleted the ci_codecov-bash branch May 18, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant