Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNB: Blacken notebooks #180

Merged
merged 5 commits into from Jun 18, 2021
Merged

Conversation

scottclowe
Copy link
Member

Convert notebooks to the Black code style

Add a pre-commit hook to ensure notebooks always conform to the Black format.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #180 (cf17610) into master (fd9d282) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files           8        8           
  Lines         831      831           
  Branches      165      165           
=======================================
  Hits          770      770           
  Misses         31       31           
  Partials       30       30           
Flag Coverage Δ
unittests 92.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9d282...cf17610. Read the comment docs.

@scottclowe
Copy link
Member Author

This didn't affect cells starting with cell magic, so I'm fixing that now.

Copy link
Member

@swkeemink swkeemink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first time learning about the black code style, so I just wanted to link the main site about the style for PR clarity:
https://black.readthedocs.io/en/stable/

Otherwise very happy with this PR, should use this in future projects.

@scottclowe scottclowe merged commit ad8dad1 into rochefort-lab:master Jun 18, 2021
@scottclowe scottclowe deleted the jnb_blacken branch June 18, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants