Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Use os.path.join and not str concat slash #71

Merged
merged 1 commit into from
Mar 17, 2020
Merged

MAINT: Use os.path.join and not str concat slash #71

merged 1 commit into from
Mar 17, 2020

Conversation

scottclowe
Copy link
Member

Better inter-operating system support.

@scottclowe
MAINT: Use os.path.join and not str concat slash
e4add98 
Better inter-operating system support.
@scottclowe
Copy link
Member Author

Re-based onto master so merge could apply.

@scottclowe scottclowe added the vX.Y.Z New Patch Release This should be included in a patch release label Jul 11, 2019
@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files           9        9           
  Lines         666      666           
  Branches      129      129           
=======================================
  Hits          528      528           
  Misses         94       94           
  Partials       44       44
Impacted Files Coverage Δ
fissa/core.py 90.18% <85.71%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d0f4e0...e4add98. Read the comment docs.

@scottclowe scottclowe mentioned this pull request Mar 9, 2020
Closed
swkeemink
swkeemink approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@swkeemink swkeemink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottclowe scottclowe merged commit 53020dd into rochefort-lab:master Mar 17, 2020
@scottclowe scottclowe deleted the maint_ospathjoin branch March 17, 2020 10:38
@scottclowe scottclowe mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swkeemink swkeemink swkeemink approved these changes

Assignees
No one assigned
Labels
vX.Y.Z New Patch Release This should be included in a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottclowe @swkeemink