Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

unify auto-signup and regular accounts #85

Merged
merged 2 commits into from
Dec 15, 2020
Merged

unify auto-signup and regular accounts #85

merged 2 commits into from
Dec 15, 2020

Conversation

phritz
Copy link
Contributor

@phritz phritz commented Dec 12, 2020

this is a necessary first step to hooking auto-signup accounts properly into the diffserver

  • move hardcoded accounts from serve/accounts to acccount/
  • present a unified account.Records interface that includes both auto-signup and regular accounts
  • remove special case for unittest account, leaving only one special case ("sandbox") where the authorization header sent is not an account id
  • serve.Service now depends on account.DB instead of an array of Accounts

@aboodman you can pull this branch, add commits, and push (or even force push) if you want. I DO NOT want to merge it until am there watching after the merge to make sure production is happy.

progress towards rocicorp/repc#269

@vercel
Copy link

vercel bot commented Dec 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/diff-server/7qdnv654g
✅ Preview: https://diff-server-git-ph-followups.rocicorp.vercel.app

@phritz phritz requested a review from aboodman December 12, 2020 03:15
@phritz
Copy link
Contributor Author

phritz commented Dec 15, 2020

@aboodman merged this so i can keep working

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant