Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add listIDs(). #11

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add listIDs(). #11

merged 1 commit into from
Sep 7, 2023

Conversation

aboodman
Copy link
Contributor

@aboodman aboodman commented Sep 7, 2023

No description provided.

@aboodman aboodman requested a review from arv September 7, 2023 20:09
@aboodman aboodman changed the title Add listKeys(). Add listIDs(). Sep 7, 2023
@aboodman aboodman enabled auto-merge (squash) September 7, 2023 20:10
@aboodman aboodman merged commit 79ab231 into main Sep 7, 2023
3 checks passed
@aboodman aboodman deleted the aa/keys branch September 7, 2023 20:10
arv
arv reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/index.test.tsx
prefix: string;
options?: ListOptions | undefined;
expected?: string[] | undefined;
expectError?: ReadonlyJSONValue | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never tested. Remove or add test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arv arv arv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboodman @arv