Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Prefix the IDB name with rep: #842

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

arv
Copy link
Contributor

@arv arv commented Feb 14, 2022

Fixes #836

@arv arv requested a review from grgbkr February 14, 2022 14:30
@vercel
Copy link

vercel bot commented Feb 14, 2022

@arv is attempting to deploy a commit to the Rocicorp Team on Vercel.

A member of the Team first needs to authorize it.

@arv
Copy link
Contributor Author

arv commented Feb 14, 2022

No test since not exposed... but I could use IDB API if we really wanted to test this?

@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/replicache/4Crob9RGs5hKENKYBaY5xDNmgR2M
✅ Preview: https://replicache-git-fork-arv-prefix-idb-name-rocicorp.vercel.app

@vercel vercel bot temporarily deployed to Preview February 14, 2022 14:31 Inactive
Copy link
Contributor

@aboodman aboodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arv arv enabled auto-merge (squash) February 14, 2022 20:35
@vercel vercel bot temporarily deployed to Preview February 14, 2022 20:35 Inactive
@arv arv merged commit 358212c into rocicorp:main Feb 14, 2022
@arv arv deleted the prefix-idb-name branch April 24, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we prefix the idb database names with "rep:"?
2 participants