Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not use window #844

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: Do not use window #844

merged 1 commit into from
Feb 15, 2022

Conversation

arv
Copy link
Contributor

@arv arv commented Feb 15, 2022

Replicache runs in web workers so we should not use window.

Replicache runs in web workers so we should not use `window`.
@arv arv requested a review from grgbkr February 15, 2022 09:29
@vercel
Copy link

vercel bot commented Feb 15, 2022

@arv is attempting to deploy a commit to the Rocicorp Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rocicorp/replicache/6WWTzV4LeHACNZEpf1U5wAM1cYYb
✅ Preview: https://replicache-git-fork-arv-no-window-rocicorp.vercel.app

@vercel vercel bot temporarily deployed to Preview February 15, 2022 09:31 Inactive
@arv arv enabled auto-merge (squash) February 15, 2022 09:31
@arv arv merged commit 3290f8e into rocicorp:main Feb 15, 2022
@arv arv deleted the no-window branch February 15, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant