This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
23 changed files
with
0 additions
and
1,127 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
bd465fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, these hooks never execute the "maj.min" and "maj" part, because they are not the latest once. But they also do no harm, sp I though it easier to have the same script in all directories.
Do you prefer to manually make sure the hooks only run in the latest versions?
bd465fd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, you lost me. But from what I can tell, we're getting the desired behavior now, right? so I think all is well.
Yes, it's very nice to have an identical script everywhere, easy to manage that way (and easier for others to both understand and reuse -- looks like this could actually be a pretty general-purpose semantic versioning hook folks could use in any Docker project that uses such versioning conventions!)