Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Commit

Permalink
drop hooks for non-latest
Browse files Browse the repository at this point in the history
  • Loading branch information
cboettig committed Aug 20, 2017
1 parent a17cdfe commit bd465fd
Show file tree
Hide file tree
Showing 23 changed files with 0 additions and 1,127 deletions.
49 changes: 0 additions & 49 deletions r-ver/3.1.0/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.2.0/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.3.0/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.3.1/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.3.2/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.3.3/hooks/post_push

This file was deleted.

49 changes: 0 additions & 49 deletions r-ver/3.4.0/hooks/post_push

This file was deleted.

2 comments on commit bd465fd

@nuest
Copy link
Contributor

@nuest nuest commented on bd465fd Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, these hooks never execute the "maj.min" and "maj" part, because they are not the latest once. But they also do no harm, sp I though it easier to have the same script in all directories.

Do you prefer to manually make sure the hooks only run in the latest versions?

@cboettig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, you lost me. But from what I can tell, we're getting the desired behavior now, right? so I think all is well.

Yes, it's very nice to have an identical script everywhere, easy to manage that way (and easier for others to both understand and reuse -- looks like this could actually be a pretty general-purpose semantic versioning hook folks could use in any Docker project that uses such versioning conventions!)

Please sign in to comment.