Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared_volumes.md #110

Closed
wants to merge 1 commit into from
Closed

Conversation

kscottz
Copy link

@kscottz kscottz commented Apr 21, 2024

Add a better example

Add a better example
Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

But I think this is too far from the containers used on this website so this is not an appropriate example.

  • Why "tb4"?
  • What is /opt/ros/container_ws/src/?

@kscottz
Copy link
Author

kscottz commented Apr 21, 2024

Why "tb4"?

Because that's the container I had in front of me. I don't care what the name as long as someone points out, "this name is the container name."

What is /opt/ros/container_ws/src/?

Because that's what I had in front of me. I would accept an arbitrary destination directory. A good alternative might be <directory_inside_container>

If you land on this page from an arbitrary Google search you have no context about the conventions that are used. It took me a good 30 to understand how to get file mounting to work correctly. I imagine most visitors to this page just want to know "How do I get this local directory to mount to a specific location within my container." I wrote an example of how to do that. All of the names are arbitrary but ROS like in nature because looking at ROS related questions led me here.

@eitsupi
Copy link
Member

eitsupi commented Apr 22, 2024

Thanks for the reply.

I don't think it is necessary to go into detail about Docker on this page that is not specific to the Rocker Project.
Links to the official Docker documentation already exist on this page, but it might be worth emphasizing that more.

@eitsupi
Copy link
Member

eitsupi commented Apr 26, 2024

@kscottz

All of the names are arbitrary but ROS like in nature because looking at ROS related questions led me here.

I did not understand why you said this, perhaps you are looking for https://github.com/osrf/rocker?
I think that project and this website where you submitted your PR are completely unrelated. (although of course they are related to Docker since the name "Rocker" comes from Docker)

I understand that you were looking for a way to do that since https://github.com/osrf/rocker seems to be focused on accessing files on the host machine from the container, but I don't think there is much demand (or at least I think it should be avoided as much as possible) for absolute path bind mounts of specific directories on the host machine in this Rocker Project to which you submitted your PR.

@kscottz
Copy link
Author

kscottz commented Apr 26, 2024

Oh my, you are correct. Sorry about the confusion.

@kscottz kscottz closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants