Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept structs #4

Merged
merged 3 commits into from
Nov 25, 2019
Merged

Accept structs #4

merged 3 commits into from
Nov 25, 2019

Conversation

rocketlaunchr-cto
Copy link
Collaborator

No description provided.

propersam
propersam approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@propersam propersam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

propersam
propersam approved these changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator

@propersam propersam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow..interesting

@propersam
Copy link
Collaborator

propersam commented Nov 25, 2019 •
edited

well, changes does not break test and changes does not require update to the test code as far I can see...unless you think otherwise...

@rocketlaunchr-cto rocketlaunchr-cto merged commit 8ea2928 into master Nov 25, 2019
@rocketlaunchr-cto rocketlaunchr-cto deleted the accept-struct branch November 25, 2019 10:05
@propersam propersam restored the accept-struct branch November 25, 2019 10:07
@pjebs pjebs deleted the accept-struct branch November 25, 2019 10:08
@propersam
Copy link
Collaborator

propersam commented Nov 25, 2019 •
edited

i am yet to add the tag....
update:
I see tag v1.1.5 has been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@propersam propersam propersam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rocketlaunchr-cto @propersam