Fix Tesla middlewares #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockneurotiko
requested changes
Oct 12, 2019
lib/ex_gram/adapter/tesla.ex
Outdated
| end | ||
| end | ||
|
|
||
| defp format_middleware({_, _} = mf), do: mf |
There was a problem hiding this comment.
This should return {:ok, mf} right?
lib/ex_gram/adapter/tesla.ex
Outdated
| defp format_middleware(_), do: :error | ||
|
|
||
| defp custom_middlewares() do | ||
| (Application.get_env(:ex_gram, __MODULE__, [])[:middlewares] || []) |
There was a problem hiding this comment.
Save this to a variable, I think having parenthesis before a pipe doesn't look good
lib/ex_gram/adapter/tesla.ex
Outdated
| |> Enum.reduce([], fn elem, acc -> | ||
| case format_middleware(elem) do | ||
| {:ok, middleware} -> | ||
| IO.inspect(middleware) |
| case format_middleware(elem) do | ||
| {:ok, middleware} -> | ||
| IO.inspect(middleware) | ||
| [middleware | acc] |
There was a problem hiding this comment.
Be careful, this will return the middlewares reversed as how it was defined in the config, and the order is important in middlewares
lib/ex_gram/adapter/tesla.ex
Outdated
| [middleware | acc] | ||
|
|
||
| :error -> | ||
| Logger.debug("Discarded, element is not a middleware: #{inspect(elem)}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix #36