Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoneminder-latest image deprecated? #319

Closed
Tracked by #335
Hooverdan96 opened this issue May 21, 2022 · 11 comments · Fixed by #336
Closed
Tracked by #335

zoneminder-latest image deprecated? #319

Hooverdan96 opened this issue May 21, 2022 · 11 comments · Fixed by #336

Comments

@Hooverdan96
Copy link
Member

The image underlying the zoneminder-latest.json https://hub.docker.com/r/dlandon/zoneminder has a deprecation notice on it. Is there a newer image that could be carried forward or keep this one in place (since the image is still there) for some more time while figuring out what to do.
@Hooverdan96 Hooverdan96 mentioned this issue May 21, 2022
Merged
5 tasks
@phillxnet
Copy link
Member

We do need to either remove the Rock-on associated with deprecated images, or find a drop in (if possible) image I think. Otherwise it dies on us out of the blue. And it's more support area also.

If there is forum activity post a removal then we can erge folk to resurect the associated Rock-on with an appropriate replacement image. Otherwise we are leading folks down an known dead end, with likely progressively more issues as time goes along; if not outright failure as per a recent issue of this you highlighted.

So I favour removing if the image is deprecated, before it get to be removed entirely. It will only get older and more of an issue.
Plus we can't carry an infinite number of Rock-ons. And I super keen to have all work and non deprecated really. At least while are eyes-on. Otherwise there will be even more issues down the line when we next have time to tend to such things.
We are after all a relatively small team, and folks can always run local Rock-on json definitions if it is mission critical. And any we remove can also always be retrieved from git anyway, given a still existing image of course.

Thanks again for the extensive review of our current Rock-ons. Much appreciated.

@Hooverdan96
Copy link
Member Author

Maybe @magicalyak can chime in here, since he created that Rockon a while ago. @magicalyak are you still using that one, or have you moved on to a newer/updated version that we could build off of?

@wwwizzarrdry
Copy link

wwwizzarrdry commented May 23, 2022 •
edited
Loading

Running CentOs Rockstor version: 3.9.2-57

Wish I had found this topic prior to installing the rockon a moment ago. In all my prep work, I never saw anything related to this docker image being deprecated... ugh.

Anyone know how to add a working, custom rockon image for zoneminder? Some pointers would be greatly appreciated.

@phillxnet
Copy link
Member

@wwwizzarrdry Hello there.
Re:

Anyone know how to add a working, custom rockon image for zoneminder? Some pointers would be greatly appreciated.

Take a look at the Readme in this repo. You can always add in your own custom Rock-on json definition by just creating a local directory and dropping in the custom Rock-on definition. All instructions in the Readme. You might also want to create an issue on the forum as many there have developed many of the Rock-ons in this repo. Including this one I believe.

You just have to be careful not to overlap with any names in this Repo. That way yours will be 'seen'. If/when we end up removing this one you can always just add it back in locally exactly as it is. The file concerned would be:

https://github.com/rockstor/rockon-registry/blob/master/zoneminder-latest.json

But again, don't install it locally, without first changing it's name. Unless we have already removed it. In which case there will be no overlap.

https://forum.rockstor.com/

We try to depricate images that are unmaintained. Clicking on the image link within your Rock-on should show it's Docker Hub details and they are showing as it having been depricated. We are just following Docker Hub's info on this one. Hence our move to deprecating it. If you can find a well maintained alternative then do please link in here. Better still a pull request of the required changes. ;). We would then be happy to replace/modify this one to a currently supported one.

Hope that helps.

@Hooverdan96
Copy link
Member Author

@wwwizzarrdry just to add. The image is marked as deprecated in the docker hub (and the github repo as well). I think for now, if it is still working fine, it is safe to use (and maybe move it locally as @phillxnet described). There are a few other images out there, but it seems like the owner of this image made a remark about some component being phased out in newer versions (which I couldn't figure out from the release notes in the newer version). If you go hunting for a newer image and figure out to install that eventually, please share your findings so that we can start using an updated version again.

@wwwizzarrdry
Copy link

The docker image doesn't work. It says it finished the install, but when you click the link to open the web ui, it doesn't work.

Same deal with the RocketChat image. Seems like the Rock-Ons list isn't being maintained anymore.

@phillxnet
Copy link
Member

@wwwizzarrdry Thanks for the feedback on the failing zoneminder-latest Rock-on. What version of Rockstor are you having this issue with?

Also

Same deal with the RocketChat image.

Care to open an issue with your findings.

Seems like the Rock-Ons list isn't being maintained anymore.

This is it's maintenance. @Hooverdan96 has now re-done all 80 of our existing Rock-on descriptions to standardise them and to add their architecture compatibilities via the following just reviewed pull request:
#310
and you should see the benefits of this rather large effort hopefully later today.
In turn they have opened 9 other issues that are in the process of being addressed, and all have had progress of sorts, along with an associated forum announcement here:
https://forum.rockstor.com/t/deprecating-stale-dead-rockons-feedback-from-rockstor-community-requested/8400

So do jump in and see what you can contribute regarding your Rocket chat findings as it may well be something easy to sort. Or a miss-configuration of sorts. Have you read our following doc section:
https://rockstor.com/docs/interface/overview.html

Hope that helps and do let us know here and in your issue on the Rocket chat rock-on failure the Rockstor version you are using. And please keep in mind that our Rock-ons maintenance does tend to come in waves. And you are on one as it goes ;). Also note @Hooverdan96 last comment here regarding the maintainers comments regarding their docker efforts of Zoneminder. Thanks

@phillxnet
Copy link
Member

Just noting here that I have had a recent report via support email that our zoneminder Rock-on install failed. There were other associated failures but just wanted to add this report here just in case.
@Hooverdan96 and @FroggyFlox same comment here as I've just made in our failing RocketChat issue:
#326 (comment)
I.e. if a relatively swift community fix is not forth-comming and non of our more regular Rock-on developers takes the reins on a broken or in need of update Rock-on then lets just delete it. It's a horribly frustrating experience all around to have obviously broken Rock-ons and our Rock-on dev team is not appreciably growing at the rate we add Rock-ons. If more we more pro-actively delete first we may end up encouraging folks to re-submit working versions - and avoid growing our support surface to larger that we have effectively maintained. Broken Rock-ons, for months, are a clear statement that we have overreached on the support surface and that is very easily remedied by more rapidly removing broken stuff rather than leaving it to tarnish the overall efforts everywhere else.

Our current Rock-on count is 81.

@phillxnet phillxnet mentioned this issue Sep 24, 2022
Closed
9 tasks
phillxnet added a commit to phillxnet/rockon-registry that referenced this issue Sep 24, 2022
@phillxnet
Remove all non-functional or outdated Rock-ons rockstor#335
08db87a 
Removes all Rock-ons associated with GitHub issues:
- Drop deprecated Subsonic Rock-On ... rockstor#307 (recent activity here).
- Subsonic Rockon container last update 5 yrs ago rockstor#316 (related to above)
- owncloud-official.json and owncloudHTTPS.json should be
updated/deprecated rockstor#313
- Rockon Postgres Versions stale? rockstor#314
- Xeoma image stale? rockstor#318
- zoneminder-latest image deprecated? rockstor#319
- Rocket.chat Rockon non-functional rockstor#326

## Also includes:
- Remove orphaned home-assistant.json (missing root.json entry).
- "Watchtower offical" which should read: "Watchtower official"
@phillxnet phillxnet mentioned this issue Sep 24, 2022
Merged
1 task
@magicalyak
Copy link
Contributor

magicalyak commented Sep 26, 2022 via email

@phillxnet
Copy link
Member

@magicalyak Hello again.

Remind me, is it better to submit a new rockon or update the old one (it's been forever for me sorry!).

I think in this case given we now have the pending pr:

#336

which has removed zoneminder-latest and rocket.chat, so it's likely going to be better to just have a new pr to submit a new entry I think, especially once that pr has been finally tested/reviewed and merged. But we also have some recent activity that may be easier to merge first so we will have to see who that all pans out. We have fallen a little behind in our tidy-up side of things on the Rock-on repo so I was doing a quick removal of all currently broken stuff without further ado given the time many of these Rock-ons have been reported broken. But as mentioned any can always be added back and I think this may be a better approach going forward as we can far faster delete than mend given our resources. I.e. if it's know broken I'm strongly leaning towards quick removal until a replacement or fix of the prior version is submitted and reviewed. This way we don't leave so many broken Rock-ons just hanging around to frustrate folks while we await reviews and testing time among our Rock-on aware developers.

If you do fancy doing any more of your magic there that would be dandy, as always; and thanks for popping in again. Much appreciated.

@magicalyak
Copy link
Contributor

magicalyak commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all non-functional or outdated Rock-ons #335 phillxnet/rockon-registry
4 participants
@wwwizzarrdry @phillxnet @magicalyak @Hooverdan96