Remove all non-functional or outdated Rock-ons #335 #336
Conversation
Removes all Rock-ons associated with GitHub issues: - Drop deprecated Subsonic Rock-On ... rockstor#307 (recent activity here). - Subsonic Rockon container last update 5 yrs ago rockstor#316 (related to above) - owncloud-official.json and owncloudHTTPS.json should be updated/deprecated rockstor#313 - Rockon Postgres Versions stale? rockstor#314 - Xeoma image stale? rockstor#318 - zoneminder-latest image deprecated? rockstor#319 - Rocket.chat Rockon non-functional rockstor#326 ## Also includes: - Remove orphaned home-assistant.json (missing root.json entry). - "Watchtower offical" which should read: "Watchtower official"
|
In keeping with the proposed approach embodied by this pr and detailed in the associated issue I've now tested this pr on a local repo from a system that previously used the production repo and all intended deletes look to have taken effect, with a no-errors update there after. Merging to clear the way for our more recent activity on new Rock-ons in this repo. If you have pending fixes for any of these removed Rock-ons then do please open a new pull request based on current master post this pr's merge as we can then re-test /review re-add as needed without leaving dead Rock-ons in production in the mean time. Better all around hopefully. |
|
@FroggyFlox & @Hooverdan96 my apologies for merging this without review. Just trying to do a little towards getting out Rock-ons repo a little lighter on the backlog and remove any pressure to fix broken stuff that has thus received insufficient attention so we can clear the way for more currently active pull requests and make the entire repo a little more approachable, hopefully. In the future I propose we move to delete fast any non functional Rock-ons, thus freeing resources and reducing frustration all around. A fix is always better, if presented and reviewed in a timely manner, but far harder to come by. And no deletion precludes a later fix and re-add. |
phillxnet
deleted the
335_Remove_all_non_functional_or_outdated_Rock-ons
branch
|
PR product production published. |
|
@phillxnet thanks for driving this to closure. I trust that your test would have revealed any issues before the merge. No concern from my side. |
Removes all Rock-ons associated with GitHub issues:
Partly addresses #307
Fixes #316 (already closed as duplicate of above but referencing here for info purposes)
Fixes #313
Fixes #314
Fixes #318
Fixes #319
Fixes #326
Ready for review.
Also includes:
Checklist