Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new Folding@home Rock-on using the linuxserver.io docker image. Fixes #219 #220

Merged

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Mar 24, 2020

Includes:

  • root.json addition.
  • Nvidia env hard wired for simplicity in anticipation of future GPU capabilities within the Rock-on system via a newer docker subsystem.

Fixes #219

@FroggyFlox Ready for review.
Note that I have slight concerns about the use of the '@' char in the root.json file. Easier for us to test post pull request submission however.

General information on project

This pull request proposes to add a new rock-on for the following project:

  • name: Folding@home
  • website: https://foldingathome.org/
  • description: "...distributed computing project for simulating protein dynamics, including the process of protein folding and the movements of proteins implicated in a variety of diseases." quoted from their about page. This project is of recognised scientific import and depends on community members volunteering part of their CPU / GPU hardware resources.

Information on docker image

  • docker image: https://hub.docker.com/r/linuxserver/foldingathome
  • is an official docker image available for this project?: I couldn't find one, however linuxserver.io are a trusted supplier and often offer UID & GID capabilities over and above many official docker images and their offering for this project was updated 4 days ago.

Checklist

  • Passes JSONlint validation
  • Entry added to root.json in alphabetical order (for new rock-on only)
  • "description" object lists and links to the docker image used
  • "description" object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)
  • "website" object links to project's main website

Testing:

  • Stopping and Starting works as expected and successfully resumes an ongoing FAH ‘Work Unit’.
  • Turning off, Un-installing, and then Re-installing with the same share also successfully resumes the FAH ‘Work Unit’.
  • After a Rockstor system reboot the Rock-on also successfully resumed the current FAH ‘Work Unit’.
  • N.B. the optional FAHControl app was note tested, and neither was wiping the entry of this optional port selection (i.e. establishing if it was actually optional within the Rock-on framework).

…ckstor#219

Includes:
- root.json addition.
- Nvidia env hard wired for simplicity in anticipation of future GPU
capabilities within the Rock-on system via newer docker subsystem.
@phillxnet
Copy link
Member Author

Attaching images of resulting additional Web-UI components:

Install verify settings dialog:

settings-review

Installed:

FAH_Rock-on_installed

Spanner icon:

FAH-Rock-on_spanner-page

Info icon:

FAH-Rock-on-info-page

Resulting Rock-on Web-UI via button:

(post job, pre job details)
Web-UI_using_defauls

@phillxnet phillxnet added the needs review Test install, function, on / off behaviour, all links / info. label Mar 24, 2020
@phillxnet
Copy link
Member Author

The docker image was noted to be around 220 MB installed:

leap15-1:~ # docker image list
REPOSITORY                  TAG                 IMAGE ID            CREATED             SIZE
linuxserver/foldingathome   latest              c5638145bde0        4 days ago          218MB

@phillxnet
Copy link
Member Author

@FroggyFlox I have now done an end-to-end test of the repo with this pr pre-merged and the result hosted locally. A Leap15-2 beta based Rockstor instance, reconfigured to use this local repo, then worked as expected with the resulting Rock-on.

A further concern re:

Note that I have slight concerns about the use of the '@' char ...

I think we are OK on this front as when I checked the function of our emergency delete-rockon script all looks to also function as expected; bar the Python version warnings (See: "move to python 3" issue rockstor/rockstor-core#1877):

leap15-2:~ # /opt/rockstor/bin/delete-rockon 
/opt/rockstor/eggs/setuptools-46.0.0-py2.7.egg/pkg_resources/py2_warn.py:22: UserWarning: Setuptools will stop working on Python 2
************************************************************
You are running Setuptools on Python 2, which is no longer
supported and
>>> SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release (no sooner than 2020-04-20).
Please ensure you are installing
Setuptools using pip 9.x or later or pin to `setuptools<45`
in your environment.
If you have done those things and are still encountering
this message, please comment in
https://github.com/pypa/setuptools/issues/1458
about the steps that led to this unsupported combination.
************************************************************
  sys.version_info < (3,) and warnings.warn(pre + "*" * 60 + msg + "*" * 60)
Delete metadata, containers and images of a Rock-on
        Usage: /opt/rockstor/bin/delete-rockon <rockon name>

And using the displayed name containing the '@' char we have:

leap15-2:~ # /opt/rockstor/bin/delete-rockon 'Folding@home Linuxserver.io'
/opt/rockstor/eggs/setuptools-46.0.0-py2.7.egg/pkg_resources/py2_warn.py:22: UserWarning: Setuptools will stop working on Python 2
************************************************************
You are running Setuptools on Python 2, which is no longer
supported and
>>> SETUPTOOLS WILL STOP WORKING <<<
in a subsequent release (no sooner than 2020-04-20).
Please ensure you are installing
Setuptools using pip 9.x or later or pin to `setuptools<45`
in your environment.
If you have done those things and are still encountering
this message, please comment in
https://github.com/pypa/setuptools/issues/1458
about the steps that led to this unsupported combination.
************************************************************
  sys.version_info < (3,) and warnings.warn(pre + "*" * 60 + msg + "*" * 60)
Rock-On(Folding@home Linuxserver.io) metadata in the db is deleted

@FroggyFlox
Copy link
Member

Thanks @phillxnet !
It does seem like you've tested it rather well and given I'm unlikely to have time to test and review it quickly, do not wait for me if you want to.

I'm sorry for the trouble, but these times are very very busy for me unfortunately.

@phillxnet
Copy link
Member Author

@FroggyFlox Thanks and no worries. I think I'll take the plunge then :).

@phillxnet phillxnet merged commit 50bd520 into rockstor:master Mar 25, 2020
@phillxnet phillxnet deleted the 219_folding-at-home_linuxserver branch March 25, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Test install, function, on / off behaviour, all links / info.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folding at home Rock-on
2 participants