-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new Folding@home Rock-on using the linuxserver.io docker image. Fixes #219 #220
add new Folding@home Rock-on using the linuxserver.io docker image. Fixes #219 #220
Conversation
…ckstor#219 Includes: - root.json addition. - Nvidia env hard wired for simplicity in anticipation of future GPU capabilities within the Rock-on system via newer docker subsystem.
The docker image was noted to be around 220 MB installed:
|
@FroggyFlox I have now done an end-to-end test of the repo with this pr pre-merged and the result hosted locally. A Leap15-2 beta based Rockstor instance, reconfigured to use this local repo, then worked as expected with the resulting Rock-on. A further concern re:
I think we are OK on this front as when I checked the function of our emergency delete-rockon script all looks to also function as expected; bar the Python version warnings (See: "move to python 3" issue rockstor/rockstor-core#1877):
And using the displayed name containing the '@' char we have:
|
Thanks @phillxnet ! I'm sorry for the trouble, but these times are very very busy for me unfortunately. |
@FroggyFlox Thanks and no worries. I think I'll take the plunge then :). |
Includes:
Fixes #219
@FroggyFlox Ready for review.
Note that I have slight concerns about the use of the '@' char in the root.json file. Easier for us to test post pull request submission however.
General information on project
This pull request proposes to add a new rock-on for the following project:
Information on docker image
Checklist
root.json
in alphabetical order (for new rock-on only)"description"
object lists and links to the docker image used"description"
object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"
object links to project's main websiteTesting: