Logitech Media Server (Squeezebox), move to latest release tag #283
Conversation
switch to latest stable branch of docker container
Add new Rockon for latest stable LMS (Squeezebox Server) version.
There was a problem hiding this comment.
Hi @Hooverdan96,
Thanks a lot for working to keep this Rock-on up-to-date. I completely agree with you on using the latest tag and creating a new Rock-on for it and then deprecating the previous one.
I'll try to find some time to properly test it on both architectures supported but in the meantime, I think we should include similar mentions as what we added in the previous Rock-on with regards to the fact that the webUI port must be set to 9000 as it uses host networking.
Once we have that in and once I can verify it works as intended on both architectures, I'll merge this in.
Thanks again for yet another crucial update from you; sorry I couldn't get to spend time on it sooner.
lms_latest.json
Outdated
| { | ||
| "Logitech Media Server - Latest Stable": { | ||
| "description": "Logitech Media Server (aka Squeezebox, slimserver, etc.). Latest stable version. For future updates see more information icon after first installation<p>Uses custom docker image: <a href='https://hub.docker.com/r/doliana/logitech-media-server' target='_blank'>https://hub.docker.com/r/doliana/logitech-media-server</a>. Available for amd64, arm/v7 &arm64 architecture.", | ||
| "more_info": "<h4>Update to newer version</h4><p>After first installation: to update to a newer stable version, either uninstall/reinstall the Rockon or use the Watchtower Rockon to manage the update of the underlying Media Server image, as it does not automatically update itself during a stop/restart of the Rockon like some other Rockons do. Don't use the update option within the LMS!</p><p>The LMS configuration files will remain in place on the volumes that were specified during the initial installation</p>", |
There was a problem hiding this comment.
Similar to the previous LMS Rock-on you worked on, maybe we should mention that the webUI port MUST be set to 9000. You had the following mention in the previous LMS Rock-on:
<p>Due to some current <a href='https://github.com/rockstor/rockstor-core/issues/2209' target='_blank'>limitations in rock-on networking</a>, the web UI port of this rock-on must be set as 9000 and will thus prevent the installation of other rock-ons needing this port. Alternatively, the web UI can be accessed manually at http://rockstor-ip:9000</p>
Co-authored-by: FroggyFlox <30297881+FroggyFlox@users.noreply.github.com>
Note that 9000 port needs to be used until net=host can be deprecated
|
@FroggyFlox - I have accepted the port change suggestion from you, as well as added the justification for the port setting to the more_info tag, unless you think it needs to be in the description of the WebUI port directly. |
|
Thanks a lot! I'll try to give it a final test asap on multiple architecture and Leap versions. I don't think we need to add justification in the port description field as I feel it would be too much information in that particular spot, which would thus be counterproductive. Thanks a lot for such a nice contribution and well-written PR; always a pleasure to work on yours! Sorry again it took me so long to find some time to look at it. |
There was a problem hiding this comment.
@Hooverdan96 , I've now tested it and can confirm it installs, runs, can be turned OFF, uninstalled, and re-installed on:
- Rockstor 4.0.9 on Leap15.3 x86_64
- Rockstor 4.0.9 on Leap15.2 Raspberry Pi4
- Rockstor 4.0.9 on Leap15.3 Raspberry Pi4
Thanks again for yet another excellent contribution!
Thanks to Hooverdan96 @thedrjones and @FroggyFlox for doing much of the leg-work on this one via organisation and replacement rock-ons. Removes definitions and root.json references for: - NZBHydra we have NZBHydra2 now via pr rockstor#272 Fixes rockstor#273 - Zoneminder 1.29 & ZoneMinder-1.30 we have `latest` via rockstor#189 @magicalyak Fixes rockstor#260 - TFTP Server redundant as we now have linuxserver/netbootxyz via rockstor#234 Fixes rockstor#257 - Plexpy image deprecated / replaced by Tautulli via rockstor#256 Fixes rockstor#255 - Koel image removed. Fixes rockstor#254 - Cardigann replaced by our existing Jackett via rockstor#68 (thanks @porkie02) Fixes rockstor#253 - Logitech(Squeezebox) replaced by LMS - Latest via rockstor#283 Fixes rockstor#281
Fixes #282.
General information on project
This pull request proposes to add a new rock-on for the following project:
Information on docker image
net=hostoption, because some of the plug-ins require multi-cast (e.g. the apple bridge, as well as some of the other plugins). Once docker is capable of routing multi-cast correctly, this option can be dropped. Alternatively, once Rockstor is completely migrated to OpenSuse, the Rocknet might be able to support this. If so, then we can change/update this one (as well as others without the host network option), but it will make installation also more involved ...Checklist
root.jsonin alphabetical order (for new rock-on only)"description"object lists and links to the docker image used"description"object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"object links to project's main website