-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates jellyfin rockon configuration #345
Conversation
the jellyfin docker image offers two additional ports which enable Service and Client Discovery (DLNA). these are now configurable via the RockOn UI interface
@kanecko thanks for submitting the updated Rockon. Enabling the DLNA discovery among other things is a good idea. A couple of things:
|
Thanks a lot for keeping an eye on that and for sharing an update, @kanecko! @Hooverdan96 made two excellent points so I have nothing to add there. I have to admit that I am surprised to see that these two ports need to be defined for this Rock-On, though. If I remember correctly, we indeed use host networking on this one for the same reason(s) as for Emby (and Plex): DLNA and other automated discovery services that go with these media servers to facilitate users' experience. I was thus thinking that DLNA for Jellyfin would work without specifying these two ports. Note that because we are using host networking, adding these two ports to the Rock-On definition should not change the current situation as Docker simply ignores the That being said, maybe we should consider adding these two ports as you do here, and remove host networking if that will not hurt the user experience (read ease of client setup and use). After all, it would be far better from a security standpoint not to use host networking. |
@FroggyFlox another good point from you. It would be good if @kanecko can confirm. If I compare the write-up on linuxserver's jellyfin vs. plex, it seems like jellyfin does not actually need the |
@kanecko We haven't forgotten about this PR by the way. Are you still interested in following-through. Just doing a tidy re backlog in Rock-ons repo? Would you rather resubmit a new pull request once you are ready? Thanks. |
I do not have time currently. |
@kanecko No worries. I'll close by way of house keeping. If anyone is interested in pursuing this further please note your progress from where this left off and we can re-open accordingly. |
the jellyfin docker image offers two additional ports which enable Service and Client Discovery (DLNA).
these are now configurable via the RockOn UI interface
Fixes #344 .
Checklist
root.json
in alphabetical order (for new rock-on only)"description"
object lists and links to the docker image used"description"
object provides information on the image's particularities (advantage over another existing rock-on for the same project, for instance)"website"
object links to project's main website