Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rock-ons] Users can add empty labels #2018

Closed
FroggyFlox opened this issue Feb 23, 2019 · 0 comments
Closed

[Rock-ons] Users can add empty labels #2018

FroggyFlox opened this issue Feb 23, 2019 · 0 comments

Comments

@FroggyFlox
Copy link
Member

As detailed in #1999 by @phillxnet, one can add empty labels (if no characters are entered in the form field). This is currently not dealt with and result in a partly empty record in the database. Most importantly, this situation is without any use and needs to be corrected.

This was entirely due to an oversight on my end as part of PR #1999.

I have a simple fix that I am about to submit as a new PR fixing this issue.
FroggyFlox added a commit to FroggyFlox/rockstor-core that referenced this issue Feb 24, 2019
@FroggyFlox
Skip empty label fields
55412a3 
Add simple if statement to ignore fields with empty values for labels.

Fixes rockstor#2018.
@FroggyFlox FroggyFlox mentioned this issue Feb 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FroggyFlox