New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated Log Errors for shares with disabled quotas #2236
Comments
@GeoffAd Thanks for creating this issue.
This is not generally the case but can end up being so if one uses the system pool (named 'ROOT' in v4 onwards) due to dockers unwarranted interaction with quotas on occasions. I also think we have a quota disabled issue on some imports of data pools but haven't pinned that one down yet. But whatever, your main issue here stands. We shouldn't any longer consider quotas disabled as an error. But it used to be so this is just a bit of our history showing through. Thanks again for creating this issue. Much appreciated. |
I am currently working on this issue., |
Linking for context to the forum origin of this issue: |
Remove explicit logging of key 'btrfs qgroup show' commands to avoid excessive log spamming. As we have now supported the pool quota disabled state mostly successfully for some time we can remove the initial default of always logging these commands which are reported as errors by the underlying btrfs commands when quotas are disabled on the parent pool. And hence are at odds with their supported state within the Rockstor Web-UI. In most common cases we catch and log as info in addition to the prior 'raw' command log. Prior explicit log parameters have been kept as explicit to ease reversing this change.
…isabled_quotas repeated log errors on disabled quotas (#2236)
Excellent stuff, thanks @phillxnet |
Probably just a bit of LOG housekeeping really, but currently shares with quotas disabled are being repeatedly logged as Errors. Example extract from Rockstor Log:
[16/Dec/2020 18:27:33] ERROR [system.osi:174] non-zero code(1) returned by command: ['/usr/sbin/btrfs', 'qgroup', 'show', '/mnt2/ROOT/home']. output: [''] error: ["ERROR: can't list qgroups: quotas not enabled", '']
Logs are repeatedly filled with this 'ERROR', which isn't an error as ROOT pool share quotas are disabled by default, and other non-ROOT share quotas might also be disabled by user. This information could be of use at times when tracking down other errors, so could these items be managed separately as DEBUG to avoid unnecessary filling of logs?
The text was updated successfully, but these errors were encountered: