Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated Log Errors for shares with disabled quotas #2236

Closed
GeoffAd opened this issue Dec 17, 2020 · 4 comments · Fixed by #2271
Closed

Repeated Log Errors for shares with disabled quotas #2236

GeoffAd opened this issue Dec 17, 2020 · 4 comments · Fixed by #2271
Assignees

Comments

@GeoffAd
Copy link

GeoffAd commented Dec 17, 2020

Probably just a bit of LOG housekeeping really, but currently shares with quotas disabled are being repeatedly logged as Errors. Example extract from Rockstor Log:

[16/Dec/2020 18:27:33] ERROR [system.osi:174] non-zero code(1) returned by command: ['/usr/sbin/btrfs', 'qgroup', 'show', '/mnt2/ROOT/home']. output: [''] error: ["ERROR: can't list qgroups: quotas not enabled", '']

Logs are repeatedly filled with this 'ERROR', which isn't an error as ROOT pool share quotas are disabled by default, and other non-ROOT share quotas might also be disabled by user. This information could be of use at times when tracking down other errors, so could these items be managed separately as DEBUG to avoid unnecessary filling of logs?

@phillxnet
Copy link
Member

@GeoffAd Thanks for creating this issue.
Re:

as ROOT pool share quotas are disabled by default

This is not generally the case but can end up being so if one uses the system pool (named 'ROOT' in v4 onwards) due to dockers unwarranted interaction with quotas on occasions.
See:
"docker-ce dictating pool quota enabled disabled status"
#1906
for some background and a link to an upstream issue link.

I also think we have a quota disabled issue on some imports of data pools but haven't pinned that one down yet.

But whatever, your main issue here stands. We shouldn't any longer consider quotas disabled as an error. But it used to be so this is just a bit of our history showing through.

Thanks again for creating this issue. Much appreciated.

@phillxnet phillxnet added this to the First 4 Stable (ISO) milestone Jan 23, 2021
@phillxnet phillxnet self-assigned this Jan 24, 2021
@phillxnet
Copy link
Member

I am currently working on this issue.,

@phillxnet
Copy link
Member

Linking for context to the forum origin of this issue:
https://forum.rockstor.com/t/repeated-qgroup-error-in-rockstor-log/7505

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 30, 2021
Remove explicit logging of key 'btrfs qgroup show' commands to
avoid excessive log spamming. As we have now supported the pool quota
disabled state mostly successfully for some time we can remove the
initial default of always logging these commands which are reported as
errors by the underlying btrfs commands when quotas are disabled on the
parent pool. And hence are at odds with their supported state within
the Rockstor Web-UI. In most common cases we catch and log as info in
addition to the prior 'raw' command log.

Prior explicit log parameters have been kept as explicit to ease
reversing this change.
phillxnet added a commit that referenced this issue Feb 1, 2021
…isabled_quotas

repeated log errors on disabled quotas (#2236)
@GeoffAd
Copy link
Author

GeoffAd commented Feb 1, 2021

Excellent stuff, thanks @phillxnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants