Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OS base version indicator more obvious #2668

Closed
phillxnet opened this issue Sep 1, 2023 · 4 comments
Closed

Make OS base version indicator more obvious #2668

phillxnet opened this issue Sep 1, 2023 · 4 comments

Comments

@phillxnet
Copy link
Member

We have had a number of reports indicating our OS version 'mouse-over' is not accessible / lacks affordance. It is proposed that we remove this mouse-over and instead indicate our base OS version directly in the header. Hopefully then removing the potential confusion with the Linux kernel version.

Current state example:
uses-openSUSE-mouse_over_example

Proposed text would then read:

Uses openSUSE Leap: 15.5 Linux: ...

@Hooverdan96
Copy link
Member

Hooverdan96 commented Sep 4, 2023

var distroInfo = function(data) {
$('#distro-info').text("Uses " + data.distro);
$('#distro-info').attr('title', data.version);
};

possibly could be as simple as changing this to:

 var distroInfo = function(data) { 
     $('#distro-info').text("Uses " + data.distro + ": " + data.version); 
     $('#distro-info').attr('title', data.version); 
 }; 

and either leave the mouse-over or get rid of it entirely. For Tumbleweed installs the version is a bit longer, given that it's comprised of yyyymmdd:

image

@phillxnet
Copy link
Member Author

phillxnet commented Sep 4, 2023

@Hooverdan96 Yes, that was what I was hoping. Thanks for looking further into this.

and either leave the mouse-over or get rid of it entirely.

I say the mouse over would then be redundant, so we simply drop it. I also don't think the long Tumbleweed version is a problem myself.

This obscure version surfacing (or lack there of) has come up as a failing a number of times now so I think it would be good to get this sorted during the current testing cycle.

Hooverdan96 added a commit to Hooverdan96/rockstor-core that referenced this issue Sep 4, 2023
@Hooverdan96
Copy link
Member

Hooverdan96 commented Sep 4, 2023

I created a pull request. I did not test it with a TW build though, which I hope is ok.

I closed the first pull request, as I put it into the incorrect branch on my side. That's remediated now, and the new one appears below this comment.

phillxnet added a commit that referenced this issue Sep 15, 2023
surface Distro Version to breadcrumb bar #2668
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants