Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django REST Framework within Django version constraint #2695

Closed
phillxnet opened this issue Oct 12, 2023 · 4 comments
Closed

Update Django REST Framework within Django version constraint #2695

phillxnet opened this issue Oct 12, 2023 · 4 comments
Assignees
Milestone

Comments

@phillxnet
Copy link
Member

As part of our current effort to update our dependencies, we have the following pinning:
djangorestframework = "==3.9.3"
This should be re-assessed give our recent Python and Django updates. And to help with our pending update to Django 3.2 by way of the linked Milestone.

@phillxnet phillxnet added this to the Django 3.2 milestone Oct 12, 2023
@phillxnet phillxnet self-assigned this Oct 12, 2023
@phillxnet
Copy link
Member Author

phillxnet commented Oct 12, 2023

From:
We have:

Requirements
REST framework requires the following:

Python (3.6, 3.7, 3.8, 3.9, 3.10)
Django (2.2, 3.0, 3.1, 3.2, 4.0, 4.1)
We highly recommend and only officially support the latest patch release of each Python and Django series.

However we have no mention of Django 2.2 on the latest version's PyPi page:
https://pypi.org/project/djangorestframework/

For security reasons we need at least 3.11.2 However the page for this version:
https://pypi.org/project/djangorestframework/3.11.2/ states Django 2.2 as the last latest version.

From https://www.django-rest-framework.org/community/release-notes/#3140
3.14.0 improves support re newer Py3.9 capabilities, but drops Django 2.2:

So we still require a pin of sorts to avoid loosing our current stepping stone of Django 2.2.

And for our in-comming Django 3.2 Milestone we see that
3.13.0 has: https://www.django-rest-framework.org/community/release-notes/#3130

  • Django 4.0 compatability. ...

Current pinning candidate: last of 3.13 series: 3.13.1

PyPi page has:

  • Django 2.2 -> 4.0
  • Python 3.6 ->: 3.10

@phillxnet
Copy link
Member Author

phillxnet commented Oct 12, 2023

lbuildvm:/opt/rockstor # poetry update
Updating dependencies
Resolving dependencies... (7.3s)

Writing lock file

Package operations: 0 installs, 1 update, 0 removals

  • Updating djangorestframework (3.9.3 -> 3.13.1)

no new migrations:

export DJANGO_SETTINGS_MODULE=settings
lbuildvm:/opt/rockstor # poetry run django-admin makemigrations

No changes detected

And the new tree view for this package:

djangorestframework 3.13.1 Web APIs for Django, made easy.
├── django >=2.2
│   ├── pytz * 
│   └── sqlparse >=0.2.2 
└── pytz *

@phillxnet
Copy link
Member Author

All tests pass, moving to Draft PR for end-to-end build test.

@phillxnet phillxnet changed the title Update Django REST Framework Update Django REST Framework within Django version constraint Oct 12, 2023
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 12, 2023
…r#2695

Move to newest version within current Django version constraint.
Django 2.2 -> 4.0
Python 3.6 -> 3.10
phillxnet added a commit that referenced this issue Oct 12, 2023
…work-within-Django-version-constraint

Update Django REST Framework within Django version constraint #2695
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant