-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdraid member status not updated and transition to multi use Disk.role field. Fixes #1214 #1314
mdraid member status not updated and transition to multi use Disk.role field. Fixes #1214 #1314
Commits on May 8, 2016
-
correct logical error on removing mdraid member role rockstor#1214
Previously we only alterred the mdraid member flag to a disks role when it's fstype, as reported by scan_disks, indicated the need. However this was done within a conditional that precluded examining a 'None' fstype which is what scan_disks translates an empty string into. Hence we never updated a role db entry for a previous mdraid member once that member no longer returned an fstype. Resolved by moving the role label logic outside the previous conditional such that it now applies to all disks even if they return no fstype from scan_disks.
Configuration menu - View commit details
-
Copy full SHA for e4ca07b - Browse repository at this point
Copy the full SHA e4ca07bView commit details -
add debug logging for issue rockstor#1214
We need now to prove this works as expected so add additional logging to help.
Configuration menu - View commit details
-
Copy full SHA for 0afb13d - Browse repository at this point
Copy the full SHA 0afb13dView commit details
Commits on May 9, 2016
-
update disk model comments - role field as json rockstor#1214
Previously envisioned as space separated values, update to reflect proposed (by @suman) json format for this field.
Configuration menu - View commit details
-
Copy full SHA for 4935f06 - Browse repository at this point
Copy the full SHA 4935f06View commit details -
update disks state using json format for role rockstor#1214
Also add beginnings of accounting for roles other than mdraid member. Note this element is incomplete here. N.B. provision is included for dealing with existing legacy db entries so that they may be updated to the new json format for this role field.
Configuration menu - View commit details
-
Copy full SHA for 7ba5b28 - Browse repository at this point
Copy the full SHA 7ba5b28View commit details -
update role handlebars helper for json format rockstor#1214
Note that as previous db entries may have non json format we account for this as before and test for json format before querying mdraid property existence in role field.
Configuration menu - View commit details
-
Copy full SHA for 0c967f3 - Browse repository at this point
Copy the full SHA 0c967f3View commit details
Commits on May 12, 2016
-
preserve existing drive role info on non mdraid devices rockstor#1214
As the role field was previously used only as an mdraid member flag mechanism it would wipe all other roles, this was improved in the case mdriad members having additional roles but all roles would still be lost on non mdraid members. This is the initial patch to address roles retention in non mdraid members.
Configuration menu - View commit details
-
Copy full SHA for 8bd0aaa - Browse repository at this point
Copy the full SHA 8bd0aaaView commit details -
fix bug where removing mdraid role left empty json content rockstor#1214
Configuration menu - View commit details
-
Copy full SHA for b53e572 - Browse repository at this point
Copy the full SHA b53e572View commit details -
Configuration menu - View commit details
-
Copy full SHA for 315f0be - Browse repository at this point
Copy the full SHA 315f0beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad930d2 - Browse repository at this point
Copy the full SHA ad930d2View commit details