Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdraid member status not updated and transition to multi use Disk.role field. Fixes #1214 #1314

Merged

Commits on May 8, 2016

  1. correct logical error on removing mdraid member role rockstor#1214

    Previously we only alterred the mdraid member flag to a disks role
    when it's fstype, as reported by scan_disks, indicated the need.
    However this was done within a conditional that precluded
    examining a 'None' fstype which is what scan_disks translates an
    empty string into. Hence we never updated a role db entry for a
    previous mdraid member once that member no longer returned an
    fstype. Resolved by moving the role label logic outside the
    previous conditional such that it now applies to all disks even if
    they return no fstype from scan_disks.
    phillxnet committed May 8, 2016
    Configuration menu
    Copy the full SHA
    e4ca07b View commit details
    Browse the repository at this point in the history
  2. add debug logging for issue rockstor#1214

    We need now to prove this works as expected
    so add additional logging to help.
    phillxnet committed May 8, 2016
    Configuration menu
    Copy the full SHA
    0afb13d View commit details
    Browse the repository at this point in the history

Commits on May 9, 2016

  1. update disk model comments - role field as json rockstor#1214

    Previously envisioned as space separated values, update
    to reflect proposed (by @suman) json format for this
    field.
    phillxnet committed May 9, 2016
    Configuration menu
    Copy the full SHA
    4935f06 View commit details
    Browse the repository at this point in the history
  2. update disks state using json format for role rockstor#1214

    Also add beginnings of accounting for roles other than
    mdraid member. Note this element is incomplete here.
    N.B. provision is included for dealing with existing
    legacy db entries so that they may be updated to the
    new json format for this role field.
    phillxnet committed May 9, 2016
    Configuration menu
    Copy the full SHA
    7ba5b28 View commit details
    Browse the repository at this point in the history
  3. update role handlebars helper for json format rockstor#1214

    Note that as previous db entries may have non json
    format we account for this as before and test for
    json format before querying mdraid property existence
    in role field.
    phillxnet committed May 9, 2016
    Configuration menu
    Copy the full SHA
    0c967f3 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2016

  1. preserve existing drive role info on non mdraid devices rockstor#1214

    As the role field was previously used only as an mdraid member
    flag mechanism it would wipe all other roles, this was improved
    in the case mdriad members having additional roles but all roles
    would still be lost on non mdraid members. This is the initial
    patch to address roles retention in non mdraid members.
    phillxnet committed May 12, 2016
    Configuration menu
    Copy the full SHA
    8bd0aaa View commit details
    Browse the repository at this point in the history
  2. fix bug where removing mdraid role left empty json content rockstor#1214

    
    
    As the default db entry and the cheapest value to check is null, make
    sure we return to null when we remove the 'mdraid' member role and
    it is the last role. Also avoids unnecessary conversion to json and
    quicker reads for the majority case (data disks).
    phillxnet committed May 12, 2016
    Configuration menu
    Copy the full SHA
    b53e572 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    315f0be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad930d2 View commit details
    Browse the repository at this point in the history