Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change share and snapshot endpoints to by id and not by name. Fixes #… #1808

Merged
merged 1 commit into from Sep 8, 2017

Conversation

schakrava
Copy link
Member

…1807

ids don't change during the lifecycle of the resource and let's us rename
shares easily.

…ockstor#1807

ids don't change during the lifecycle of the resource and let's us rename
shares easily.
@schakrava schakrava merged commit be1fe57 into rockstor:master Sep 8, 2017
@phillxnet
Copy link
Member

@schakrava On a quick look at these changes I think we will have the same issue as we had earlier with the API change for pools (re:scrubs) where smart_manager_taskdefinition contains (within field json_meta) now defunct references ie "share": "luks-share" for snapshot tasks. This will presumably self correct for all new tasks (as with pool scrub tasks) but we are then left with no snapshot task json_meta name reference and will have to resolve to a name (might be tricky in places). Otherwise task tables will display the id rather than the name.

Requesting that this be debugged and fixed prior to the next stable release.

For pools I stamped the current name within the json_meta (not ideal but allowed for a work around with existing task mechanisms with only cosmetic artefacts there after) ie see:
pr #1760 "fix scheduled scrub regression re pool api changes. Fixes #1759"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants