Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable updates regression Rockstor 4 release candidate. Fixes #2227 #2228

Conversation

phillxnet
Copy link
Member

The existing url encoded stable updates credentials were not found by zypper from within the Web-UI hosted command environment. Fix by moving to explicit file storage of credentials using the default location for credentials.global.dir, see: /etc/zypp/zypp.conf.

Thanks to forum member GeoffA for reporting this issue and extensive early testing.
Thanks to @FroggyFlox for pointers and research on zypper function and capability.

Fixes #2227

Ready for review.

zypper url modifications:

  • Remove in-line password.
  • Activate built in global dir credentials retrieval via "credentials=".
  • Explicitly assert basic http auth via "auth=basic".

N.B. The 'user' element is still required within the url.

Testing

An existing 4.0.2-0 Release candidate 3 was patched in place and updated successfully via Web-UI to 4.0.3-0 (RC3) via:

  • Rockstor4 installer build with rpm 4.0.0-0 specified
  • All pending updates (non Rockstor) were applied
  • Resulting install was subscribed to Testing
  • systemctl stop rockstor rockstor-pre rockstor-bootstrap
  • zypper --non-interactive in rockstor-4.0.2-0
  • proposed changes made to pkg_mgmt.py
  • systemctl start rockstor
  • Web-UI Subscribe to Stable
  • Successfully updated to 4.0.3 placeholder rpm in Stable repo.

The last step in this case undoes the proposed changes but proves the ability of a patched 4.0.2-0 to subscribe to and update from the Stable channel.

During development and the above proof of function the Stable channel web server logs were monitored for evidence of any 401 access indicating the prior issue detailed failure to authenticate.

The existing url encoded stable updates credentials were not found by
zypper from within the Web-UI hosted command environment. Fix by moving
to explicit file storage of credentials using the default location
for credentials.global.dir, see: /etc/zypp/zypp.conf.

zypper url modifications required:
- Remove in-line password.
- Activate built in global dir credentials retrieval via "credentials=".
- Explicitly assert basic http auth via "auth=basic".

N.B. The 'user' element is still required within the url.
@phillxnet
Copy link
Member Author

Thanks to forum member GeoffA for confirming the efficacy of this authorisation change by patching an existing install and subscribing successfully re authentication. Matching web server logs were examined and no 401's were found.

@phillxnet
Copy link
Member Author

@FroggyFlox As this is pretty important and looks to at least help, and we have confirmation of it's function I'll merge and get this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable updates regression Rockstor 4 release candidate
1 participant